Bug 1375616 - Metric::Target capture_vm_targets
Summary: Metric::Target capture_vm_targets
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Performance
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: GA
: 5.6.1
Assignee: Keenan Brock
QA Contact: Pradeep Kumar Surisetty
URL:
Whiteboard: c&u
Depends On: 1374839
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-13 14:17 UTC by Satoe Imaishi
Modified: 2016-11-29 16:04 UTC (History)
5 users (show)

Fixed In Version: 5.6.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1374839
Environment:
Last Closed: 2016-11-29 16:04:57 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:


Attachments (Terms of Use)

Comment 2 Satoe Imaishi 2016-09-13 14:17:50 UTC
This was fixed in 5.6.1. Please move to CLOSED CURRENTRELEASE if verification passes.

Comment 3 Dave Johnson 2016-09-14 02:55:47 UTC
From the PR:
=======================================================
simplify capture_vm_targets

Tangentially related to #8429 and

https://bugzilla.redhat.com/show_bug.cgi?id=1332579
https://bugzilla.redhat.com/show_bug.cgi?id=1331803

Before:

    traversed all vm parents instead of the ones that we said were relevant. [performance]
    returned vms even if they did not have an ems [bug]

After:

    loop over the parents we said were relevant
    ensure the vm has an ems before returning it. This is no longer called for cloud vms, and doesn't show up for infra vms. Put this in anyway to ensure it is part of the contract.
=========================================================

Keenan, steps to verify?  Is this in reports where some VMs were included when they should not of been or is purely just a speed improvement that is going to be be hard to verify?

Comment 4 Keenan Brock 2016-09-17 00:42:19 UTC
There are a number of performance related BZs around capacity and utilization capture. The part that puts the targets (storage, host, vm) into the queue to be captured.

What you should see.

if you have 10k VMs. it will complete the capture_vm_targets job within a minute or so rather than over 10 minutes (and over the timeout threshold).

There will no longer be errors in the log.

You may want to test all of these BZs in 1 fell swoop. All of them were complaining that this process timed out, and the testing of these BZs is that it did not timeout even though there are many many vms.

Let me know if you need more info

Comment 8 Archit Sharma 2016-11-29 10:58:30 UTC
tested on 5610: 1 db appliance, 3 worker appliances, 10k vms on vcenter, w/ metrics collector worker on all appliances

As expected, completion happens within 30 seconds approx.

Script used to extract timings: https://github.com/arcolife/cfme-performance/blob/dev/adhoc-scripts/get_metric_capture_avg.sh


Note You need to log in before you can comment on or make changes to this bug.