Bug 1376123 - unit file missing Type=notify
Summary: unit file missing Type=notify
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: etcd-container
Version: 7.3
Hardware: x86_64
OS: Linux
high
high
Target Milestone: rc
: ---
Assignee: Suresh Kolichala
QA Contact: atomic-bugs@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-14 18:39 UTC by Qian Cai
Modified: 2020-09-29 12:08 UTC (History)
4 users (show)

Fixed In Version: etcd-docker-2.3.7-9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-09-29 12:08:41 UTC
Target Upstream Version:


Attachments (Terms of Use)

Comment 2 Avesh Agarwal 2016-09-15 16:43:53 UTC
I put exit 1 in the entry script for etcd container. and built locally and then tested without Type=notify in the service file, and I see that the systemctl status logs the start error correctly.

systemctl status etcd.service
● etcd.service - Etcd Server
   Loaded: loaded (/etc/systemd/system/etcd.service; enabled; vendor preset: disabled)
   Active: failed (Result: start-limit) since Thu 2016-09-15 12:39:31 EDT; 6s ago
  Process: 16412 ExecStop=/bin/runc kill etcd (code=exited, status=1/FAILURE)
  Process: 16393 ExecStart=/bin/runc start etcd (code=exited, status=1/FAILURE)
 Main PID: 16393 (code=exited, status=1/FAILURE)

Sep 15 12:39:31 rhel73 systemd[1]: Unit etcd.service entered failed state.
Sep 15 12:39:31 rhel73 systemd[1]: etcd.service failed.
Sep 15 12:39:31 rhel73 systemd[1]: etcd.service holdoff time over, scheduling restart.
Sep 15 12:39:31 rhel73 systemd[1]: start request repeated too quickly for etcd.service
Sep 15 12:39:31 rhel73 systemd[1]: Failed to start Etcd Server.
Sep 15 12:39:31 rhel73 systemd[1]: Unit etcd.service entered failed state.
Sep 15 12:39:31 rhel73 systemd[1]: etcd.service failed.

So I dont think there is an issue here.

Comment 3 Avesh Agarwal 2016-09-15 16:57:52 UTC
CAI,

Also as per systemd docuementation, Type=notify is useful when "the daemon sends a notification message via sd_notify(3) or an equivalent call when it has finished starting up".

I am not sure runc or etcd does that.

Comment 4 Avesh Agarwal 2016-09-15 17:27:22 UTC
CAI,

I think I see the difference when using Type=notify. 

#systemctl start etcd.service
Job for etcd.service failed because the control process exited with error code. See "systemctl status etcd.service" and "journalctl -xe" for details.

I think this failure is not available without Type=notify.

I will fix it next built today.


Note You need to log in before you can comment on or make changes to this bug.