Bug 1376126 - unit file missing Type=notify
Summary: unit file missing Type=notify
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: flannel-container
Version: 7.3
Hardware: x86_64
OS: Linux
high
high
Target Milestone: rc
: ---
Assignee: Jan Chaloupka
QA Contact: Martin Jenner
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-14 18:44 UTC by Qian Cai
Modified: 2020-09-29 12:08 UTC (History)
5 users (show)

Fixed In Version: flannel-docker-0.5.5-3
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-09-29 12:08:52 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Comment 3 Giuseppe Scrivano 2016-09-15 13:29:32 UTC 
there is a pull request upstream:

https://github.com/aveshagarwal/flannel-container/pull/4

that addresses this issue in a different way as we cannot use Type=notify yet.

The PID known to the container process is different than the one on the host.  We will have to figure out a way to support this in future.  CoreOS uses a separate tool (sdnotify-proxy) to convert from the container PID namespace.
Comment 4 Qian Cai 2016-09-15 14:17:24 UTC 
In addition, Type=notify is still useful to catch errors from the runc process. For example, the container ID has already existed.
Comment 5 Avesh Agarwal 2016-09-15 16:53:51 UTC 
Hi Giuseppe,

I am not sure how is your PR https://github.com/aveshagarwal/flannel-container/pull/4 is related to the issue CAI is talking about here with Type=notify?
Note You need to log in before you can comment on or make changes to this bug.