Bug 1377320 - Azure Compute Resource: Move to strong-params
Summary: Azure Compute Resource: Move to strong-params
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Compute Resources - Azure
Version: 6.3.0
Hardware: Unspecified
OS: Unspecified
high
medium vote
Target Milestone: Unspecified
Assignee: Daniel Lobato Garcia
QA Contact: Katello QA List
URL: http://projects.theforeman.org/issues...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-19 12:36 UTC by Sachin Ghai
Modified: 2019-09-26 14:02 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-30 20:00:50 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 16269 0 None None None 2016-09-19 13:03:04 UTC

Description Sachin Ghai 2016-09-19 12:36:50 UTC 
Currently installing the "foreman-azure" package on RHEL7 throws the below trace-back.

ForemanAzure::Azure is using attr_accessible so must either be converted to strong parameters, or add the protected_attributes gem (RuntimeError)
  /usr/share/foreman/config/initializers/active_record_extensions.rb:21:in `attr_accessible'
  /usr/share/foreman/app/models/concerns/optional_attr_accessible.rb:30:in `attr_accessible'
  /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_azure-1.0.1/app/models/foreman_azure/azure.rb:5:in `<class:Azure>'
  /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_azure-1.0.1/app/models/foreman_azure/azure.rb:2:in `<module:ForemanAzure>'
  /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_azure-1.0.1/app/models/foreman_azure/azure.rb:1:in `<top (required)>'
  /opt/rh/rh-ruby22/root/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require'
  /opt/rh/rh-ruby22/root/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require'
  /opt/rh/sclo-ror42/root/usr/share/gems/gems/polyglot-0.3.4/lib/polyglot.rb:65:in `require'


1) Installed setup using katello-deploy and RHEL7 UI Was accessible with latest nightly.
2) Installed Azure CR via "yum install foreman-azure"
3) Restarted the katello-service and found the above issue related to Foreman:Azure
Comment 1 Sachin Ghai 2016-09-19 12:36:55 UTC 
Created from redmine issue http://projects.theforeman.org/issues/16269
Comment 2 Sachin Ghai 2016-09-19 12:38:03 UTC 
Connecting redmine issue http://projects.theforeman.org/issues/16269 from this bug
Comment 3 Sachin Ghai 2016-09-19 12:45:22 UTC 
I see the similar issue with sat6.3 snap1:

tfm-rubygem-azure-core-0.1.1-1.el7.noarch
tfm-rubygem-azure-0.7.5-1.el7.noarch 
tfm-rubygem-fog-azure-0.0.2-1.el7.noarch 
tfm-rubygem-foreman_azure-1.0.1-1.fm1_13.el7.noarch
satellite-installer-6.3.0.0-1.git.12.695b530.el7sat.noarch


| RuntimeError: ForemanAzure::Azure is using attr_accessible so must either be converted to strong parameters, or add the protected_attributes gem
 | /usr/share/foreman/config/initializers/active_record_extensions.rb:21:in `attr_accessible'
 | /usr/share/foreman/app/models/concerns/optional_attr_accessible.rb:30:in `attr_accessible'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_azure-1.0.1/app/models/foreman_azure/azure.rb:5:in `<class:Azure>'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_azure-1.0.1/app/models/foreman_azure/azure.rb:2:in `<module:ForemanAzure>'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_azure-1.0.1/app/models/foreman_azure/azure.rb:1:in `<top (required)>'
 | /opt/rh/rh-ruby22/root/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require'
 | /opt/rh/rh-ruby22/root/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require'
Comment 6 Bryan Kearney 2016-10-03 16:19:53 UTC 
Upstream bug assigned to dlobatog
Comment 7 Bryan Kearney 2016-10-03 16:19:56 UTC 
Moving this bug to POST for triage into Satellite 6 since the upstream issue http://projects.theforeman.org/issues/16269 has been resolved.
Comment 8 Daniel Lobato Garcia 2016-12-09 10:52:27 UTC 
No longer need info from me
Note You need to log in before you can comment on or make changes to this bug.