Bug 1377910 - Thunderbird should not be build against system cairo
Summary: Thunderbird should not be build against system cairo
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: thunderbird
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Gecko Maintainer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-21 01:28 UTC by Hubert Figuiere
Modified: 2016-09-22 07:38 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-09-21 09:27:15 UTC
Type: Bug

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Hubert Figuiere 2016-09-21 01:28:12 UTC 
Thunderbird should not be build against system cairo

Like Firefox, it should be build against the provided version of cairo. Otherwise it crashes very often.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1174997#c5
Comment 1 Jan Horak 2016-09-21 09:27:15 UTC 
Hm, it seems that TB is build without system cairo by default. Why do you presume that it is build against system cairo? You are correct that we should not build against system cairo. Do you miss the explicit --disable-system-cairo in the .mozconfig?

The configuration is implemented by MOZ_TREE_CAIRO variable, which according to build log [1] is set to 1, ie using in-tree cairo. Some build flags related to cairo are introduced by GTK2 but that should not affect actual build.

Please reopen if you have some proof that I'm wrong here. Thank you.

[1] https://kojipkgs.fedoraproject.org//packages/thunderbird/45.3.0/1.fc24/data/logs/i686/build.log
Comment 2 Hubert Figuiere 2016-09-21 11:57:21 UTC 
there is a direct dependency on cairo-devel in the .spec file that Firefox doesn't. I may have been mistaken. Sorry.
Comment 3 Jan Horak 2016-09-22 07:38:46 UTC 
Okay, fair enough, I'll remove that dependency, thanks for letting us know.
Note You need to log in before you can comment on or make changes to this bug.