Spec URL: http://msimacek.fedorapeople.org/review/jetty-alpn/jetty-alpn.spec SRPM URL: http://msimacek.fedorapeople.org/review/jetty-alpn/jetty-alpn-8.1.9-1.v20160720.fc24.src.rpm Description: A pure Java(TM) implementation of the Application Layer Protocol Negotiation TLS Extension Fedora Account System Username: msimacek
Fixed typo in summary Spec URL: https://msimacek.fedorapeople.org/jetty-alpn.spec SRPM URL: https://msimacek.fedorapeople.org/jetty-alpn-8.1.9-1.v20160720.fc24.src.rpm
Build fails: [INFO] --- maven-compiler-plugin:3.5.1:testCompile (default-testCompile) @ alpn-tests --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 5 source files to /builddir/build/BUILD/jetty-alpn-alpn-project-8.1.9.v20160720/alpn-tests/target/test-classes [INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /builddir/build/BUILD/jetty-alpn-alpn-project-8.1.9.v20160720/alpn-tests/src/test/java/org/mortbay/jetty/alpn/AbstractALPNTest.java:[196,27] select(java.util.List<java.lang.String>) in <anonymous org.mortbay.jetty.alpn.AbstractALPNTest$6> cannot implement select(java.util.List<java.lang.String>) in org.eclipse.jetty.alpn.ALPN.ServerProvider overridden method does not throw javax.net.ssl.SSLException [ERROR] /builddir/build/BUILD/jetty-alpn-alpn-project-8.1.9.v20160720/alpn-tests/src/test/java/org/mortbay/jetty/alpn/AbstractALPNTest.java:[233,25] selected(java.lang.String) in <anonymous org.mortbay.jetty.alpn.AbstractALPNTest$7> cannot implement selected(java.lang.String) in org.eclipse.jetty.alpn.ALPN.ClientProvider overridden method does not throw javax.net.ssl.SSLException [ERROR] /builddir/build/BUILD/jetty-alpn-alpn-project-8.1.9.v20160720/alpn-tests/src/test/java/org/mortbay/jetty/alpn/AbstractALPNTest.java:[248,27] select(java.util.List<java.lang.String>) in <anonymous org.mortbay.jetty.alpn.AbstractALPNTest$8> cannot implement select(java.util.List<java.lang.String>) in org.eclipse.jetty.alpn.ALPN.ServerProvider overridden method does not throw javax.net.ssl.SSLException [INFO] 3 errors [INFO] ------------------------------------------------------------- [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Skipping Jetty :: ALPN :: Project [INFO] This project has been banned from the build due to previous failures. [INFO] ------------------------------------------------------------------------ [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Jetty :: ALPN :: Project ........................... SUCCESS [ 0.441 s] [INFO] Jetty :: ALPN :: Boot .............................. SUCCESS [ 4.183 s] [INFO] Jetty :: ALPN :: Tests ............................. FAILURE [ 0.465 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 7.496 s [INFO] Finished at: 2016-09-21T19:05:55+02:00 [INFO] Final Memory: 25M/174M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.5.1:testCompile (default-testCompile) on project alpn-tests: Compilation failure: Compilation failure: [ERROR] /builddir/build/BUILD/jetty-alpn-alpn-project-8.1.9.v20160720/alpn-tests/src/test/java/org/mortbay/jetty/alpn/AbstractALPNTest.java:[196,27] select(java.util.List<java.lang.String>) in <anonymous org.mortbay.jetty.alpn.AbstractALPNTest$6> cannot implement select(java.util.List<java.lang.String>) in org.eclipse.jetty.alpn.ALPN.ServerProvider [ERROR] overridden method does not throw javax.net.ssl.SSLException [ERROR] /builddir/build/BUILD/jetty-alpn-alpn-project-8.1.9.v20160720/alpn-tests/src/test/java/org/mortbay/jetty/alpn/AbstractALPNTest.java:[233,25] selected(java.lang.String) in <anonymous org.mortbay.jetty.alpn.AbstractALPNTest$7> cannot implement selected(java.lang.String) in org.eclipse.jetty.alpn.ALPN.ClientProvider [ERROR] overridden method does not throw javax.net.ssl.SSLException [ERROR] /builddir/build/BUILD/jetty-alpn-alpn-project-8.1.9.v20160720/alpn-tests/src/test/java/org/mortbay/jetty/alpn/AbstractALPNTest.java:[248,27] select(java.util.List<java.lang.String>) in <anonymous org.mortbay.jetty.alpn.AbstractALPNTest$8> cannot implement select(java.util.List<java.lang.String>) in org.eclipse.jetty.alpn.ALPN.ServerProvider [ERROR] overridden method does not throw javax.net.ssl.SSLException [ERROR] -> [Help 1]
You need latest jetty-alpn-api from rawhide. I built it yesterday, so it's probably not on mirrors yet. You can either use koji repo or install it manually from: http://koji.fedoraproject.org/koji/buildinfo?buildID=802911
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "EPL-1.0", "GPL (v2)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/gil/1378021 -jetty-alpn/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package contains no bundled libraries without FPC exception. See maven-shade-plugin and maven-bundle-plugin tasks [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jetty- alpn-javadoc [x]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: jetty-alpn-8.1.9-1.v20160720.fc26.noarch.rpm jetty-alpn-javadoc-8.1.9-1.v20160720.fc26.noarch.rpm jetty-alpn-8.1.9-1.v20160720.fc26.src.rpm jetty-alpn.noarch: E: incorrect-fsf-address /usr/share/licenses/jetty-alpn/gplv2+ce.html jetty-alpn-javadoc.noarch: E: incorrect-fsf-address /usr/share/licenses/jetty-alpn-javadoc/gplv2+ce.html 3 packages and 0 specfiles checked; 2 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- jetty-alpn.noarch: E: incorrect-fsf-address /usr/share/licenses/jetty-alpn/gplv2+ce.html jetty-alpn-javadoc.noarch: E: incorrect-fsf-address /usr/share/licenses/jetty-alpn-javadoc/gplv2+ce.html 2 packages and 0 specfiles checked; 2 errors, 0 warnings. Requires -------- jetty-alpn (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(org.eclipse.jetty.alpn:alpn-api) jetty-alpn-javadoc (rpmlib, GLIBC filtered): javapackages-tools Provides -------- jetty-alpn: jetty-alpn mvn(org.mortbay.jetty.alpn:alpn-boot) mvn(org.mortbay.jetty.alpn:alpn-boot:pom:) mvn(org.mortbay.jetty.alpn:alpn-project:pom:) osgi(org.mortbay.jetty.alpn.boot) jetty-alpn-javadoc: jetty-alpn-javadoc Source checksums ---------------- https://github.com/jetty-project/jetty-alpn/archive/alpn-project-8.1.9.v20160720.tar.gz : CHECKSUM(SHA256) this package : eacc55c60e75e4ba6293faaafefcb5b97a3d117e0dfc848ac14c092ae355ffb9 CHECKSUM(SHA256) upstream package : eacc55c60e75e4ba6293faaafefcb5b97a3d117e0dfc848ac14c092ae355ffb9 http://openjdk.java.net/legal/gplv2+ce.html : CHECKSUM(SHA256) this package : f56bd9e9f7522c6a81134d611d78c33ecd8f303ac7d1c894e4f2c99703882d7b CHECKSUM(SHA256) upstream package : f56bd9e9f7522c6a81134d611d78c33ecd8f303ac7d1c894e4f2c99703882d7b Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1378021 --plugins Java -m fedora-rawhide-i386 -L ~/deps Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Built with local dependencies: ~/deps/jetty-alpn-api-1.1.2-1.fc26.noarch.rpm
Issues: [!]: Package contains no bundled libraries without FPC exception. See maven-shade-plugin and maven-bundle-plugin tasks [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Package does not include license text files separate from upstream. jetty-alpn.noarch: E: incorrect-fsf-address /usr/share/licenses/jetty-alpn/gplv2+ce.html jetty-alpn-javadoc.noarch: E: incorrect-fsf-address /usr/share/licenses/jetty-alpn-javadoc/gplv2+ce.html
(In reply to gil cattaneo from comment #5) > Issues: > [!]: Package contains no bundled libraries without FPC exception. > See maven-shade-plugin and maven-bundle-plugin tasks Removed maven-shade-plugin. maven-bundle-plugin is for generating OSGi bundles, those are not bundling, they are just named like that. > > [!]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. > > [!]: Package does not include license text files separate from upstream. > > jetty-alpn.noarch: E: incorrect-fsf-address > /usr/share/licenses/jetty-alpn/gplv2+ce.html > jetty-alpn-javadoc.noarch: E: incorrect-fsf-address > /usr/share/licenses/jetty-alpn-javadoc/gplv2+ce.html Actually, the package is under GPL, which doesn't require license file to be distributed alongside the source. So I just removed it. Spec URL: https://msimacek.fedorapeople.org/jetty-alpn.spec SRPM URL: https://msimacek.fedorapeople.org/jetty-alpn-8.1.9-2.v20160720.fc24.src.rpm
Pòease, remove "cp -p %{SOURCE1} ."
(In reply to gil cattaneo from comment #7) > Pòease, remove "cp -p %{SOURCE1} ." Done. Spec URL: https://msimacek.fedorapeople.org/jetty-alpn.spec SRPM URL: https://msimacek.fedorapeople.org/jetty-alpn-8.1.9-3.v20160720.fc24.src.rpm
(In reply to Michael Simacek from comment #6) > (In reply to gil cattaneo from comment #5) > > Issues: > > [!]: Package contains no bundled libraries without FPC exception. > > See maven-shade-plugin and maven-bundle-plugin tasks > > Removed maven-shade-plugin. > maven-bundle-plugin is for generating OSGi bundles, those are not bundling, > they are just named like that. yes but the export/import configuration are wrong: "<Export-Package>org.eclipse.jetty.alpn;sun.security.ssl;version="${parsedVersion.majorVersion}.${parsedVersion.minorVersion}.${parsedVersion.incrementalVersion}"</Export-Package>" should be: "<Export-Package>sun.security.ssl;version="${parsedVersion.majorVersion}.${parsedVersion.minorVersion}.${parsedVersion.incrementalVersion}"</Export-Package> <Import-Package>!sun.*,org.eclipse.jetty.alpn</Import-Package>"
is not enough "%pom_remove_plugin :maven-shade-plugin". Please, use "%pom_remove_plugin -r :maven-shade-plugin". "org.eclipse.jetty.alpn:alpn-api" is till shaded: "[INFO] --- maven-shade-plugin:2.4.3:shade (default) @ alpn-boot --- [INFO] Including org.eclipse.jetty.alpn:alpn-api:jar:1.1.3.v20160715 in the shaded jar. [INFO] Replacing original artifact with shaded artifact. [INFO] Replacing /builddir/build/BUILD/jetty-alpn-alpn-project-8.1.9.v20160720/alpn-boot/target/alpn-boot-8.1.9.v20160720.jar with /builddir/build/BUILD/jetty-alpn-alpn-project-8.1.9.v20160720/alpn-boot/target/alpn-boot-8.1.9.v20160720-shaded.jar [INFO] Dependency-reduced POM written at: /builddir/build/BUILD/jetty-alpn-alpn-project-8.1.9.v20160720/alpn-boot/dependency-reduced-pom.xml"
Done Spec URL: https://msimacek.fedorapeople.org/jetty-alpn.spec SRPM URL: https://msimacek.fedorapeople.org/jetty-alpn-8.1.9-3.v20160720.fc24.src.rpm
Approved
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/jetty-alpn
Thank you for the review.