Bug 1378464 - cockpit-ovirt package includes twice patterfly related files
Summary: cockpit-ovirt package includes twice patterfly related files
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: cockpit-ovirt
Classification: oVirt
Component: Generic
Version: ---
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: ---
Assignee: Marek Libra
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-22 13:19 UTC by Sandro Bonazzola
Modified: 2017-01-18 12:42 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-10-11 07:19:59 UTC
oVirt Team: Virt
rule-engine: planning_ack?
rule-engine: devel_ack?
rule-engine: testing_ack?


Attachments (Terms of Use)

Description Sandro Bonazzola 2016-09-22 13:19:44 UTC
Due to the nodejs build several fonts, stylesheets and graphics which belong to patternfly are included in the cockpit-ovirt rpms.

patternfly3 is packaged as rpm by patternfly project here: https://copr.fedorainfracloud.org/coprs/patternfly/patternfly3/

We rely on patternfly1 from the same copr owner even in ovirt-engine.

We should rely on system provided patternfly resources instead of shipping again (twice) the patternfly's resources.

Comment 1 Marek Libra 2016-10-06 09:28:34 UTC
I thnk it's better to stay on patternfly3 in the cockpit-ovirt, so it will be aligned with the rest of the Cockpit it lives in.

The patternfly3 is provided by ovirt-engine-nodejs-modules, so shared among projects as well.

The fonts, CSS, icons files are generated during the build process as a result of webpack analyzis what resources are really needed by the resulting bundle.
I would not change that, that's a good feature.

Regarding their duplicity in the cockpit-ovirt rpm: the 'dashboard' and 'vdsm' parts are more-or-less independent subpackages with their own webpack builds resulting in the partial duplicity of the generated resource files.

Since there's ongoing activity to split the 'dashboard' even more and separate the 'vdsm' part to a new rpm, I would not change that as well.

Comment 2 Tomas Jelinek 2016-10-11 07:19:59 UTC
As per comment 1, closing.


Note You need to log in before you can comment on or make changes to this bug.