Spec URL: https://nb.fedorapeople.org/perl-Test-Mock-Guard.spec SRPM URL: https://nb.fedorapeople.org/perl-Test-Mock-Guard-0.10-1.fc24.src.rpm Description: Simple mock test library using RAII Fedora Account System Username: nb
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: License file LICENSE is marked as %doc instead of %license [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: perl-Test-Mock-Guard-0.10-1.el7.centos.noarch.rpm perl-Test-Mock-Guard-0.10-1.el7.centos.src.rpm perl-Test-Mock-Guard.noarch: W: incoherent-version-in-changelog 0.10-1 ['0.10-1.el7.centos', '0.10-1.centos'] 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- perl-Test-Mock-Guard.noarch: W: incoherent-version-in-changelog 0.10-1 ['0.10-1.el7.centos', '0.10-1.centos'] 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Requires -------- perl-Test-Mock-Guard (rpmlib, GLIBC filtered): perl perl(:MODULE_COMPAT_5.16.3) perl(Carp) perl(Class::Load) perl(Exporter) perl(List::Util) perl(Scalar::Util) perl(strict) perl(warnings) Provides -------- perl-Test-Mock-Guard: perl(Test::Mock::Guard) perl-Test-Mock-Guard Source checksums ---------------- http://www.cpan.org/authors/id/X/XA/XAICRON/Test-Mock-Guard-0.10.tar.gz : CHECKSUM(SHA256) this package : 7f228a63f8d6ceb92aa784080a13e85073121b2835eca06d794f9709950dbd3d CHECKSUM(SHA256) upstream package : 7f228a63f8d6ceb92aa784080a13e85073121b2835eca06d794f9709950dbd3d Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04 Command line :/usr/bin/fedora-review -n perl-Test-Mock-Guard -p --define DISTTAG=el7 Buildroot used: epel-7-x86_64 Active plugins: Generic, Shell-api, Perl Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, EPEL6
Approved after two minor items: * Note: License file LICENSE is marked as %doc instead of %license [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) The .spec is correct for older builds, but the standards have changed.
For some reason it isn't letting him set fedora-review+. Setting for him, per comment # 2
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Test-Mock-Guard
imapsync-1.727-1.fc25, perl-JSON-WebToken-0.10-2.fc25, perl-Test-Mock-Guard-0.10-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-17a038f8c3
imapsync-1.727-1.el7, perl-JSON-WebToken-0.10-1.el7, perl-Test-Mock-Guard-0.10-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-3f52c73207
imapsync-1.727-1.fc23, perl-JSON-WebToken-0.10-1.fc23, perl-Test-Mock-Guard-0.10-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d9ea875fa1
imapsync-1.727-1.fc24, perl-JSON-WebToken-0.10-1.fc24, perl-Test-Mock-Guard-0.10-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4980b97ebd
imapsync-1.727-1.fc25, perl-JSON-WebToken-0.10-2.fc25, perl-Test-Mock-Guard-0.10-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
imapsync-1.727-1.fc24, perl-JSON-WebToken-0.10-1.fc24, perl-Test-Mock-Guard-0.10-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
imapsync-1.727-1.fc23, perl-JSON-WebToken-0.10-1.fc23, perl-Test-Mock-Guard-0.10-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
imapsync-1.727-1.el7, perl-JSON-WebToken-0.10-1.el7, perl-Test-Mock-Guard-0.10-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.