Bug 1379068 - lvm2-activation.service has extra space in dependencies
Summary: lvm2-activation.service has extra space in dependencies
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: LVM and device-mapper
Classification: Community
Component: lvm2
Version: 2.02.165
Hardware: Unspecified
OS: Linux
unspecified
low
Target Milestone: ---
: ---
Assignee: LVM and device-mapper development team
QA Contact: cluster-qe@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-24 14:45 UTC by Timur Bakeyev
Modified: 2019-08-06 00:52 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-08-06 00:52:41 UTC
rule-engine: lvm-technical-solution?
rule-engine: lvm-test-coverage?


Attachments (Terms of Use)

Description Timur Bakeyev 2016-09-24 14:45:16 UTC
Description of problem:

Not really a problem, but rather inaccuracy(?).

Generated by lvm2-activation-generator lvm2-activation.service gets After dependency line with extra leading space:

DefaultDependencies=no
After= lvm2-activation-early.service cryptsetup.target
Before=local-fs-pre.target shutdown.target
Wants=systemd-udev-settle.service


That's not an issue, really(so far?), but would be nice to get it as:

After=lvm2-activation-early.service cryptsetup.target

--- lvm2_activation_generator_systemd_red_hat.c.orig    2016-09-24 16:44:28.741513727 +0200
+++ lvm2_activation_generator_systemd_red_hat.c 2016-09-24 16:44:42.169437227 +0200
@@ -137,7 +137,7 @@
                        fputs("After=systemd-udev-settle.service\n"
                              "Before=cryptsetup.target\n", f);
                } else
-                       fprintf(f, "After= %s cryptsetup.target\n", unit_names[UNIT_EARLY]);
+                       fprintf(f, "After=%s cryptsetup.target\n", unit_names[UNIT_EARLY]);

                fputs("Before=local-fs-pre.target shutdown.target\n"
                      "Wants=systemd-udev-settle.service\n\n"

Comment 1 Peter Rajnoha 2016-09-26 07:58:31 UTC
Applied, thanks!

https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=70be57c8dab4a011b0f6014636d3948d10ddd8c3

The patch is scheduled for lvm2 v2.02.166.


Note You need to log in before you can comment on or make changes to this bug.