Hide Forgot
Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-QtAwesome/python-QtAwesome.spec SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-QtAwesome/python-QtAwesome-0.3.3-1.fc24.src.rpm Description: QtAwesome enables iconic fonts such as Font Awesome and Elusive. It is a port to Python - PyQt / PySide of the QtAwesome C++ library by Rick Blommers. Fedora Account System Username: nonamedotc
hi Source1: MIT_license.txt is useless ...? git source archive should be contains license file https://github.com/spyder-ide/qtawesome/archive/v0.3.3/qtawesome-0.3.3.tar.gz
Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-QtAwesome/python-QtAwesome.spec SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-QtAwesome/python-QtAwesome-0.3.3-2.fc24.src.rpm This should address all the issues (as far as I can tell).
Please, use https://github.com/spyder-ide/qtawesome/archive/v0.3.3/qtawesome-0.3.3.tar.gz Otherwise you should use the approach shown here: https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Hosting_Services
Fixed. Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-QtAwesome/python-QtAwesome.spec SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-QtAwesome/python-QtAwesome-0.3.3-3.fc24.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 12 files have unknown license. Detailed output of licensecheck in /home/gil/1379092 -python-QtAwesome/licensecheck.txt License: MIT and OFL License: OFL. ./qtawesome/fonts/fontawesome-webfont.ttf ./qtawesome/fonts/elusiveicons-webfont.ttf [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files # License: OFL. #./qtawesome/fonts/fontawesome-webfont.ttf Provides: bundled(elusiveicons-fonts) = 001.000 #./qtawesome/fonts/elusiveicons-webfont.ttf Provides: bundled(fontawesome-fonts) = 4.4.1 [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-QtAwesome , python3-QtAwesome [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.2.21 starting (python version = 3.5.1)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata Mock Version: 1.2.21 INFO: Mock Version: 1.2.21 Finish: chroot init INFO: installing package(s): /home/gil/1379092-python-QtAwesome/results/python2-QtAwesome-0.3.3-3.fc26.noarch.rpm /home/gil/1379092-python-QtAwesome/results/python3-QtAwesome-0.3.3-3.fc26.noarch.rpm ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-i386/root/ --releasever 26 --disableplugin=local --setopt=deltarpm=false install /home/gil/1379092-python-QtAwesome/results/python2-QtAwesome-0.3.3-3.fc26.noarch.rpm /home/gil/1379092-python-QtAwesome/results/python3-QtAwesome-0.3.3-3.fc26.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: python2-QtAwesome-0.3.3-3.fc26.noarch.rpm python3-QtAwesome-0.3.3-3.fc26.noarch.rpm python-QtAwesome-0.3.3-3.fc26.src.rpm python2-QtAwesome.noarch: W: no-documentation python3-QtAwesome.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- python2-QtAwesome (rpmlib, GLIBC filtered): python(abi) python-qtpy python-six python3-QtAwesome (rpmlib, GLIBC filtered): python(abi) python3-qtpy python3-six Provides -------- python2-QtAwesome: python-QtAwesome python2-QtAwesome python2.7dist(qtawesome) python2dist(qtawesome) python3-QtAwesome: python3-QtAwesome python3.5dist(qtawesome) python3dist(qtawesome) Source checksums ---------------- https://github.com/spyder-ide/qtawesome/archive/v0.3.3/qtawesome-0.3.3.tar.gz : CHECKSUM(SHA256) this package : 700152aa44b6043d2de163dc5160c9e4f5f4bbfeea586c2cbb5b3bf387591d9e CHECKSUM(SHA256) upstream package : 700152aa44b6043d2de163dc5160c9e4f5f4bbfeea586c2cbb5b3bf387591d9e Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1379092 --plugins Python -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Maybe you could add %doc README.md for each pythonX sub packages
Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-QtAwesome/python-QtAwesome.spec SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-QtAwesome/python-QtAwesome-0.3.3-4.fc24.src.rpm - added license tag, doc and provides.
Many thanks for the review!
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-QtAwesome
built on rawhide.