Bug 1379777 - docker-novolume-plugin does not start when docker service restarted
Summary: docker-novolume-plugin does not start when docker service restarted
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: docker
Version: 7.3
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: rc
: ---
Assignee: Daniel Walsh
QA Contact: atomic-bugs@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-27 16:03 UTC by Chris Evich
Modified: 2019-03-06 01:52 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-09-28 13:29:46 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Chris Evich 2016-09-27 16:03:44 UTC
Description of problem:
While verifying bug 1376953, step 1 "enable docker-novolume-plugin", following the steps listed at https://github.com/projectatomic/docker-novolume-plugin#installing the plugin process did not start automatically when restarting, or stop + start, of docker service.

Version-Release number of selected component (if applicable):
rhel-atomic-host/7/x86_64/standard Version: 7.3 (2016-09-26 16:13:07)
docker-novolume-plugin-1.10.3-55.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. # vi /etc/sysconfig/docker
OPTIONS='... --authorization-plugin=docker-novolume-plugin"

2. # systemctl stop docker
3. # systemctl enable docker-novolume-plugin
4. # systemctl start docker

Actual results:
# ps waux | grep -v grep | grep plugin
root      12269  0.0  0.1  44428  6820 ?        Ssl  10:53   0:00 /usr/libexec/docker/rhel-push-plugin
root      13766  0.2  0.6 352936 24712 ?        Ssl  11:39   0:00 /usr/bin/docker-current...


Expected results:
# ps waux | grep -v grep | grep plugin
root        728  0.0  0.1  40592  4068 ?        Ssl  11:59   0:00 /usr/libexec/docker/docker-novolume-plugin
root       6113  0.2  0.6 297968 26152 ?        Ssl  11:59   0:00 /usr/bin/docker-current...
root      12222  0.0  0.1  43372  5876 ?        Ssl  12:00   0:00 /usr/libexec/docker/rhel-push-plugin


Additional info:
I can manually start the service with 'systemctl start docker-novolume-plugin' and then everything works as expected.

Comment 2 Daniel Walsh 2016-09-27 18:07:36 UTC
Shouldn't you just enable docker-novolume-plugin.  It should not stop when the docker service stops.

Comment 3 Chris Evich 2016-09-27 18:19:48 UTC
Enabling the service works fine, however the service does not start on boot, nor does it start when the docker service is started/restarted.

Comment 4 Daniel Walsh 2016-09-27 18:42:53 UTC
Ok if the service does not start on boot then you have a bug.

Is there a failure in the logs stating why it did not start?

Comment 5 Chris Evich 2016-09-27 19:11:52 UTC
TBH, I didn't check, was focused on verifying the bug 1376953.  I can manually start it w/o a problem: systemctl start docker-novolume-plugin.  It's just the automatic start dependency from docker service that doesn't work.  I'll make sure it's enabled, reboot, and check the logs....

Comment 6 Chris Evich 2016-09-27 19:20:01 UTC
Hrmmm, okay, after rebooting, it did come up this time.  So maybe it was my goof.  Double-checking to see if I can make it break the same as before...

Comment 7 Chris Evich 2016-09-27 19:27:17 UTC
Okay, so it doesn't appear it starts w/o rebooting:

# systemctl status docker-novolume-plugin
● docker-novolume-plugin.service - Docker No volumes authZ Plugin
   Loaded: loaded (/usr/lib/systemd/system/docker-novolume-plugin.service; enabled; vendor preset: disabled)...cut...

# systemctl stop docker-novolume-plugin

# systemctl stop docker-novolume-plugin.socket

# systemctl disable docker-novolume-plugin

# systemctl disable docker-novolume-plugin.socket

# systemctl status docker-novolume-plugin
● docker-novolume-plugin.service - Docker No volumes authZ Plugin
   Loaded: loaded (/usr/lib/systemd/system/docker-novolume-plugin.service; disabled; vendor preset: disabled)...cut...

# systemctl stop docker

# vi /etc/sysconfig/docker
(plugin is still listed in OPTIONS)

# systemctl enable docker-novolume-plugin
Created symlink from /etc/systemd/system/multi-user.target.wants/docker-novolume-plugin.service to /usr/lib/systemd/system/docker-novolume-plugin.service.

# systemctl status docker-novolume-plugin
● docker-novolume-plugin.service - Docker No volumes authZ Plugin
   Loaded: loaded (/usr/lib/systemd/system/docker-novolume-plugin.service; enabled; vendor preset: disabled)
   Active: inactive (dead) since Tue 2016-09-27 15:17:09 EDT; 4min 5s ago
   ...cut...

# systemctl start docker
(waited a few seconds)

# systemctl status docker-novolume-plugin
● docker-novolume-plugin.service - Docker No volumes authZ Plugin
   Loaded: loaded (/usr/lib/systemd/system/docker-novolume-plugin.service; enabled; vendor preset: disabled)
   Active: inactive (dead) since Tue 2016-09-27 15:17:09 EDT; 4min 19s ago
   ...cut...

So it's def. not starting with just the docker service. But...

# reboot
Connection to 1.2.3.4 closed by remote host.

# ssh 1.2.3.4...

# systemctl status docker-novolume-plugin
● docker-novolume-plugin.service - Docker No volumes authZ Plugin
   Loaded: loaded (/usr/lib/systemd/system/docker-novolume-plugin.service; enabled; vendor preset: disabled)
   Active: active (running) since Tue 2016-09-27 15:25:28 EDT; 39s ago

So it's fine after rebooting.  Maybe this is expected behavior then?

Comment 8 Lokesh Mandvekar 2016-09-27 19:55:28 UTC
Chris could you check if you experience similar behavior with rhel-push-plugin?

Comment 9 Daniel Walsh 2016-09-27 21:55:33 UTC
I see this as not a bug.  There is no relationship between docker and docker-novolume-plugin, IE We don't state that one needs to run for the other.  Although I think there is or was a link that say docker-novolume-plugin needs to start before docker starts.

To make this work you would need to do

systemctl enable docker-novolume-plugin
systemctl start docker-novolume-plugin
systemctl enable docker
systemctl start docker

And you should be all set.

Comment 10 Chris Evich 2016-09-28 13:27:32 UTC
(In reply to Lokesh Mandvekar from comment #8)
> Chris could you check if you experience similar behavior with
> rhel-push-plugin?

I did not.  The rhel-push-plugin was already up and running on first-boot.  I didn't even need to enable it.

Comment 11 Chris Evich 2016-09-28 13:29:46 UTC
(In reply to Daniel Walsh from comment #9)
> I see this as not a bug.  There is no relationship between docker and
> docker-novolume-plugin, IE We don't state that one needs to run for the
> other.  Although I think there is or was a link that say
> docker-novolume-plugin needs to start before docker starts.
> 
> To make this work you would need to do
> 
> systemctl enable docker-novolume-plugin
> systemctl start docker-novolume-plugin
> systemctl enable docker
> systemctl start docker
> 
> And you should be all set.

Yep, this seems to be the case.  The incorrect / missing text is here:
https://github.com/projectatomic/docker-novolume-plugin#installing

So, I guess we can call this a docs bug :D

Comment 12 Chris Evich 2016-09-28 13:36:09 UTC
Doc. Fix: https://github.com/projectatomic/docker-novolume-plugin/pull/12


Note You need to log in before you can comment on or make changes to this bug.