Bug 1379864 - Rules Engine does not match what it claims to match
Summary: Rules Engine does not match what it claims to match
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Bugzilla
Classification: Community
Component: Internal Tools
Version: 4.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified vote
Target Milestone: 4.4
Assignee: Matt Tyson 🤬
QA Contact: tools-bugs
URL:
Whiteboard:
: 1338506 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-27 22:58 UTC by Matt Tyson 🤬
Modified: 2018-12-09 06:29 UTC (History)
4 users (show)

Fixed In Version: 4.4.12063.3
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-28 00:13:49 UTC

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Matt Tyson 🤬 2016-09-27 22:58:16 UTC 
The rules engine search code doesn't match what it claims to match when displaying a list of bugs that match a rule.

The rules engine when given a condition like this:

'Keywords' 'contains any of the strings' 'Keyword1 Keyword2 Keyword3'

Will claim to match bugs with those three keywords.

When it comes time to run the rule, no bugs are matched.  This is because the code that executes the rules requires the search terms to be comma separated.

'Keywords' 'contains any of the strings' 'Keyword1,Keyword2,Keyword3'.
Comment 1 Matt Tyson 🤬 2016-09-27 23:02:17 UTC 
The actual search code used in the advanced search page expects this to be comma separated.  I'm not sure why the rules engine thinks that space separators are valid.
Comment 2 Matt Tyson 🤬 2016-11-10 04:46:07 UTC 
(In reply to Matt Tyson from comment #1)
> The actual search code used in the advanced search page expects this to be
> comma separated.  I'm not sure why the rules engine thinks that space
> separators are valid.

Actually, that's not right at all.  The advanced search works with spaces or commas.

The problem was happening when the rule engine was performing the match while processing the bug.
Comment 3 Matt Tyson 🤬 2016-11-11 04:28:44 UTC 
*** Bug 1338506 has been marked as a duplicate of this bug. ***
Comment 4 Rony Gong 🔥 2016-11-15 08:42:35 UTC 
Tested on QA environment(4.4.12063-2)
Result: Pass
Steps:
1.Create a rule with blow detail:

    Classification is 'Red Hat'
    Product is 'Auto Test'
    Status is 'POST'
    Any Resolution
    Any Component
    Any Target Milestone
    Any Target Release
    Any Keywords
    Any Group
    'Keywords' 'contains any of the strings' 'Security Bugfix SELinux'

Then:

    Change the Status field to 'ASSIGNED'
    No changes to the 'Resolution' value.
    No changes to the 'Target Milestone' value.
    No changes to the 'Target Release' value.
    No changes to the 'Keywords' value.
    No changes to the 'Group' value.
    No changes to the 'CC' value.
    No changes to flags.
    No comment will be made.
    No notification will be sent.
2. Then create a Auto Test bug with status set 'POST'
and Keyword set Bugfix
==>This bug could be hit by this rule.
Comment 5 Matt Tyson 🤬 2016-11-28 00:13:49 UTC 
This change is now live. If there are any issues, do not reopen this bug.
Instead, you should create a new bug and reference this bug.
Note You need to log in before you can comment on or make changes to this bug.