Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1380160

Summary: Type=notify unable to honor sd-notify processes
Product: Red Hat Enterprise Linux 7 Reporter: Qian Cai <qcai>
Component: runcAssignee: Lokesh Mandvekar <lsm5>
Status: CLOSED CURRENTRELEASE QA Contact: atomic-bugs <atomic-bugs>
Severity: high Docs Contact: Yoana Ruseva <yruseva>
Priority: high    
Version: 7.3CC: avagarwa, lsm5, mpatel, smahajan, yruseva
Target Milestone: rcKeywords: Extras
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-01 19:43:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Qian Cai 2016-09-28 19:40:19 UTC
Description of problem:
Trying to add Type=notify to system containers unit file in order to catch errors from runc start.

# cat /etc/systemd/system/etcd.service 
[Unit]
Description=Etcd Server
After=network.target
After=network-online.target
Wants=network-online.target

[Service]
Type=notify
ExecStart=/bin/runc start 'etcd'
ExecStop=/bin/runc kill 'etcd'
Restart=on-failure
WorkingDirectory=/sysroot/ostree/deploy/rhel-atomic-host/var/lib/containers/atomic/etcd.0
RuntimeDirectory=etcd

[Install]
WantedBy=multi-user.target

However, it ends up with "systemctl start etcd" hang. Steps to reproduce below,

# atomic uninstall etcd
# runc delete etcd
# atomic install --system --name=etcd brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/rhel7/etcd:latest
# systemctl start etcd

Only thing seems to get it working is to append -d to runc start in the unit file, but that causes both runc list and atomic containers list not correctly list the running containers.

# rpm -q runc atomic
runc-0.1.1-6.el7.x86_64
atomic-1.12.5-2.el7.x86_64

Developer confirmed that etcd is a sd-notify process, and the original etcd rpm uses Type=notify as well.

# cat /usr/lib/systemd/system/etcd.service 
[Unit]
Description=Etcd Server
After=network.target
After=network-online.target
Wants=network-online.target

[Service]
Type=notify
WorkingDirectory=/var/lib/etcd/
EnvironmentFile=-/etc/etcd/etcd.conf
User=etcd
# set GOMAXPROCS to number of processors
ExecStart=/bin/bash -c "GOMAXPROCS=$(nproc) /usr/bin/etcd --name=\"${ETCD_NAME}\" --data-dir=\"${ETCD_DATA_DIR}\" --listen-client-urls=\"${ETCD_LISTEN_CLIENT_URLS}\""
Restart=on-failure
LimitNOFILE=65536

[Install]
WantedBy=multi-user.target

Comment 3 Qian Cai 2017-01-26 14:54:47 UTC
This one is still broken with the latest bits. Any progress?

Comment 4 Mrunal Patel 2017-02-06 22:49:17 UTC
See https://github.com/opencontainers/runc/pull/1308

Comment 5 Qian Cai 2017-03-14 19:42:06 UTC
Lokesh, this patch is now merged upstream, how do you think of rebasing runc in 7.3.4?

Comment 6 Lokesh Mandvekar 2017-03-14 19:43:57 UTC
sure thing, I"ll rebase