Bug 1380545 - Bogus rules engine warnings when configuring a flagtype
Summary: Bogus rules engine warnings when configuring a flagtype
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Bugzilla
Classification: Community
Component: Internal Tools
Version: 4.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified vote
Target Milestone: ---
Assignee: Matt Tyson 🤬
QA Contact: tools-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-30 00:02 UTC by Matt Tyson 🤬
Modified: 2017-01-30 01:00 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-01-30 01:00:38 UTC


Attachments (Terms of Use)

Description Matt Tyson 🤬 2016-09-30 00:02:27 UTC
The rules engine will supply a warning when you attempt to edit a flagtype that is used by a rule.

This error seems to be given when it shouldn't be given (see attached RT)

I think it is detecting that the flagtype matches a regex in the rule search condition.

It should probably only supply a warning if the flag is explicitly used as a match or update condition

Comment 1 Matt Tyson 🤬 2016-12-06 01:42:21 UTC
Instead of removing the warning, we'll just update the warning to be a little clearer.

Changing a flag type of a custom field match won't cause the rules engine to throw the kill switch.  It will only affect how the rule matches flags.

Comment 3 Rony Gong 🔥 2016-12-20 07:14:19 UTC
Tested on QA environment(5.0.3-rh19)
Result: Pass
Steps:
1.The warning message changed to:
WARNING: This flag type is currently used on the following Rule Engine rules. Certain changes (like changing the name, category, requestability or the active state) may cause the rule to not match, or the Rules Engine to stop.

Note that 'custom field' rule matches will not cause the Rules Engine to fail, but could cause the rule to stop matching.

Comment 4 Rony Gong 🔥 2017-01-09 08:39:10 UTC
Tested on QA environment(4.4.12065-1.el6)
Result: Pass
Steps:
1.The warning message changed to:
WARNING: This flag type is currently used on the following Rule Engine rules. Certain changes (like changing the name, category, requestability or the active state) may cause the rule to not match, or the Rules Engine to stop.

Note that 'custom field' rule matches will not cause the Rules Engine to fail, but could cause the rule to stop matching.

Comment 5 Matt Tyson 🤬 2017-01-30 01:00:38 UTC
This change is now live. If there are any issues, do not reopen this bug.                                                                                                           
Instead, you should create a new bug and reference this bug.


Note You need to log in before you can comment on or make changes to this bug.