Bug 1380919 - libguestfs should allow the usage of mkisofs too
Summary: libguestfs should allow the usage of mkisofs too
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libguestfs
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-01 13:44 UTC by Pacho Ramos
Modified: 2016-10-02 09:18 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-10-02 09:18:26 UTC


Attachments (Terms of Use)

Description Pacho Ramos 2016-10-01 13:44:07 UTC
cdrkit is dead and unmaintained for ages. The problem is that we still need it to provide genisoimage for libguestfs. Wouldn't it be possible to allow to (at least) optionally use mkisofs (from cdrtools)?

Thanks a lot for your help

Comment 1 Richard W.M. Jones 2016-10-01 15:12:36 UTC
My previous answer was here:
https://bugs.gentoo.org/show_bug.cgi?id=591782#c1

"The reason for the cdrkit requirement is to pull in "genisoimage"
and the isotools (isodump, isoinfo, etc.)

If those are available from another package in Gentoo, then you
just need to substitute those in the build dependencies, and I
think no other change should be required."

---

Fedora has both genisoimage and mkisofs symlinked to each other.

Upstream libguestfs will check for genisoimage followed by mkisofs,
so most likely you can remove the cdrkit requirement and it should
still work.

Apart from that I don't really know anything about the history of
these tools, but if you do then surely this is an easy patch since
we only use genisoimage (the command) in a single place in the code.

Comment 2 Pacho Ramos 2016-10-02 09:18:26 UTC
It looks to work fine indeed, thanks and sorry for the noise


Note You need to log in before you can comment on or make changes to this bug.