Bug 1381304 - RFE: provide all properties of LVs/VGs/PVs that the liblvm library's objects provide
Summary: RFE: provide all properties of LVs/VGs/PVs that the liblvm library's objects ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: LVM and device-mapper
Classification: Community
Component: lvm2
Version: 2.02.166
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Tony Asleson
QA Contact: cluster-qe@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-03 15:57 UTC by Vratislav Podzimek
Modified: 2017-09-13 15:40 UTC (History)
8 users (show)

Fixed In Version: 2.02.167
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-09-13 15:40:59 UTC
rule-engine: lvm-technical-solution?
rule-engine: lvm-test-coverage?

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Vratislav Podzimek 2016-10-03 15:57:39 UTC 
Description of problem:
LVM DBus API doesn't provide all properties for LVs/VGs/PVs that the liblvm API provides (e.g. "data_percent" for an LV). This prevents users of the liblvm API (e.g. storaged) from moving to the new DBus API (via libblockdev-lvm-dbus).
Comment 1 Vratislav Podzimek 2016-10-05 09:07:00 UTC 
If liblvm provides all properties, it will be enough (for now) to add properties required by storaged. [1]

[1] https://github.com/storaged-project/storaged/blob/master/modules/lvm2/udiskslvmhelper.c#L122 (and the other show_*() functions)
Comment 2 Tony Asleson 2016-10-05 20:58:52 UTC 
Changes committed upstream:

https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=a3f24aaf5cfe9983a59ce200d0a0d8050658c8b8

https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=d54ffcfcd12981a8e046aca0a82d529221015b30

https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=a8bb8dfb08d38cfda5493ca9d35d1cb3bf2d32bf
Comment 3 Vratislav Podzimek 2016-10-06 08:21:14 UTC 
(In reply to Tony Asleson from comment #2)
> Changes committed upstream:
> 
> https://git.fedorahosted.org/cgit/lvm2.git/commit/
> ?id=a3f24aaf5cfe9983a59ce200d0a0d8050658c8b8
> 
> https://git.fedorahosted.org/cgit/lvm2.git/commit/
> ?id=d54ffcfcd12981a8e046aca0a82d529221015b30
> 
> https://git.fedorahosted.org/cgit/lvm2.git/commit/
> ?id=a8bb8dfb08d38cfda5493ca9d35d1cb3bf2d32bf

Looks good to me. Thanks!
Note You need to log in before you can comment on or make changes to this bug.