Bug 1381697 - [RFE] S30samba-start.sh should configure Windows' "Previous Versions" / shadow_copy2 by default
Summary: [RFE] S30samba-start.sh should configure Windows' "Previous Versions" / shado...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Gluster Storage
Classification: Red Hat
Component: samba
Version: rhgs-3.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Michael Adam
QA Contact: storage-qa-internal@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-04 18:43 UTC by John Call
Modified: 2016-10-17 17:24 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-10-17 07:43:49 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description John Call 2016-10-04 18:43:15 UTC
The hook script to initialize Samba shares from Gluster volumes does not configure shadow_copy2 and other parameters required for Windows' Previous Version functionality to work.  Additional manual configuration is required.  This RFE would add the necessary configurations to the S30samba-start.sh so that this functionality just works / out-of-the-box.

Would you please consider adjusting the hook script so that the share definition looks like this?


[myVol]
    comment = Gluster myVol via libgfapi
    path = /
    guest ok = Yes
    read only = No
    vfs objects = shadow_copy2 glusterfs
    shadow:format = _GMT-%Y.%m.%d-%H.%M.%S
    shadow:snapprefix = *  <-- can this be a wild card?
    shadow:sort = desc
    shadow:basedir = /
    shadow:snapdir = /.snaps
    glusterfs:loglevel = 7
    glusterfs:logfile = /var/log/samba/glusterfs-myVol.%M.log
    glusterfs:volume = myVol

Comment 2 Sayan Saha 2016-10-10 17:48:45 UTC
I would urge the 3.2 program team to consider this RFE for inclusion in RHGS 3.2. It's mostly a usability enhancement.

Comment 3 Michael Adam 2016-10-17 07:43:49 UTC
We don't actually want to do this:

Adding shadow-copy to the config adds an overhead to the share
access. So it should only be done when snapshots are really used.

We _could_ think about doing this not by default
buy under certain special conditions to be defined.
But then again, we do actually want to move away from the
hook-script model of setting up samba shares. (It is hacked,
in-flexible and buggy.)

So currently it is a conscious decision that the admin should
add the shadow-copy parts to the config if desired.


Note You need to log in before you can comment on or make changes to this bug.