Bug 1382024 - [RFE] Detect windows line endings (cause %post to silently fail)
Summary: [RFE] Detect windows line endings (cause %post to silently fail)
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: pykickstart
Version: 7.3
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: David Cantrell
QA Contact: Release Test Team
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-05 14:32 UTC by Fabian Deutsch
Modified: 2019-03-15 18:46 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-03-15 18:46:36 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Fabian Deutsch 2016-10-05 14:32:24 UTC 
Description of problem:
Currently windows line endings in a %post let can cause an %post-let to fail.
It will even fail silently if --erroronfail is not given.

This condition can be checked and can probably be avoided.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create a ks with \r chars in a %post --erroronfail seciton
2. Start an automated install using this ks
3. anaconda will fail

Actual results:
anaconda will silently fail

Expected results:
anaconda will fail with an error - or correct the line endings

Additional info:
Comment 1 Martin Kolman 2017-01-18 14:04:47 UTC 
I guess the scriptlets could be checked & fixed when the kickstart is being parsed. So maybe this is something for Pykickstart ? Adding Chris to CC.
Comment 2 Samantha N. Bueno 2017-05-26 16:11:03 UTC 
We did not get to this in 7.4, so deferring to 7.5 planning.
Comment 3 Samantha N. Bueno 2017-09-01 11:25:18 UTC 
We were unable to include this into our workload for 7.5, but we'd still like to look into this issue, so deferring it to 7.6 planning.
Comment 4 Jiri Konecny 2018-04-25 11:39:51 UTC 
Based on the comment 1 the best component to fix this issue would be pykickstart. Changing component.
Comment 7 David Cantrell 2019-03-15 18:46:36 UTC 
Filed upstream:
https://github.com/dcantrell/pykickstart/issues/260
Note You need to log in before you can comment on or make changes to this bug.