Bug 1382280 - readpath() creates incorrect leading directories
Summary: readpath() creates incorrect leading directories
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: python-libarchive
Version: 24
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Dhiru Kholia
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-06 08:47 UTC by Simon Rowe
Modified: 2017-08-08 19:20 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-08 19:20:39 UTC
Type: Bug


Attachments (Terms of Use)
Patch (549 bytes, patch)
2016-10-06 08:47 UTC, Simon Rowe
no flags Details | Diff

Description Simon Rowe 2016-10-06 08:47:30 UTC
Created attachment 1207866 [details]
Patch

Description of problem:

When readpath() is called with a filename (string) it is intended that any leading directories are created before writing the contents of the entry to a file.


Version-Release number of selected component (if applicable):

python-libarchive-3.1.2.1-7.fc24.x86_64.rpm


How reproducible:

100%

Steps to Reproduce:

The following code should extract all entries in an archive

import os.path
import stat

import libarchive

with libarchive.Archive("test.tar") as a:
    for entry in a:
        p = os.path.join("output", entry.pathname)
        if not stat.S_ISDIR(entry.mode):
            a.readpath(p)


Actual results:

IOError: [Errno 2] No such file or directory

because directories do not exist


Expected results:

Archive extracted.


Additional info:

Patch to resolve this attached.

I've looked for the upstream project to report this there but code.google.com gives 404.

Comment 1 Orion Poplawski 2016-10-06 22:33:59 UTC
FWIW there seem to be some alternative python interfaces:
https://pypi.python.org/pypi?%3Aaction=search&term=libarchive&submit=search

Maybe time to just retire python-libachive as nothing seems to require it.

Comment 2 Orion Poplawski 2016-10-06 22:35:01 UTC
And fedora has:

python2-libarchive-c.noarch : Python interface to libarchive
python3-libarchive-c.noarch : Python interface to libarchive

Comment 3 Fedora End Of Life 2017-07-25 23:22:53 UTC
This message is a reminder that Fedora 24 is nearing its end of life.
Approximately 2 (two) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 24. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '24'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 24 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 4 Fedora End Of Life 2017-08-08 19:20:39 UTC
Fedora 24 changed to end-of-life (EOL) status on 2017-08-08. Fedora 24 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.