Bug 1382711 - RFE - show relative change of offset
Summary: RFE - show relative change of offset
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: libabigail
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Sinny Kumari
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-07 13:22 UTC by Marek Kašík
Modified: 2018-02-01 09:23 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-02-01 09:23:35 UTC
Type: Bug


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Sourceware 20887 0 None None None 2016-11-30 13:19:48 UTC

Description Marek Kašík 2016-10-07 13:22:13 UTC
Description of problem:
It would be handy to see relative change of offset when a data member changes its offset in a data structure. Right now we get for example this:

1 data member deletion:
  'FT_Generic FT_LibraryRec_::generic', at offset 64 (in bits) at ftobjs.h:816:1

11 data member changes:
 'FT_Int FT_LibraryRec_::version_major' offset changed from 192 to 64 (in bits)
 'FT_Int FT_LibraryRec_::version_minor' offset changed from 224 to 96 (in bits)
 'FT_Int FT_LibraryRec_::version_patch' offset changed from 256 to 128 (in bits)
 'FT_UInt FT_LibraryRec_::num_modules' offset changed from 288 to 160 (in bits)
 'FT_Module FT_LibraryRec_::modules[32]' offset changed from 320 to 192 (in bits)
 'FT_ListRec FT_LibraryRec_::renderers' offset changed from 2368 to 2240 (in bits)
 'FT_Renderer FT_LibraryRec_::cur_renderer' offset changed from 2496 to 2368 (in bits)
 'FT_Module FT_LibraryRec_::auto_hinter' offset changed from 2560 to 2432 (in bits)
 'FT_Byte* FT_LibraryRec_::raster_pool' offset changed from 2624 to 2496 (in bits)
 'FT_ULong FT_LibraryRec_::raster_pool_size' offset changed from 2688 to 2560 (in bits)
 'FT_DebugHook_Func FT_LibraryRec_::debug_hooks[4]' offset changed from 2752 to 2624 (in bits)


It would be great if I could see there something like this:

1 data member deletion:
  'FT_Generic FT_LibraryRec_::generic', at offset 64 (in bits) at ftobjs.h:816:1

11 data member changes:
 'FT_Int FT_LibraryRec_::version_major' offset changed from 192 to 64 (by 128 bits)
 'FT_Int FT_LibraryRec_::version_minor' offset changed from 224 to 96 (by 128 bits)
 'FT_Int FT_LibraryRec_::version_patch' offset changed from 256 to 128 (by 128 bits)
 'FT_UInt FT_LibraryRec_::num_modules' offset changed from 288 to 160 (by 128 bits)
 'FT_Module FT_LibraryRec_::modules[32]' offset changed from 320 to 192 (by 128 bits)
 'FT_ListRec FT_LibraryRec_::renderers' offset changed from 2368 to 2240 (by 128 bits)
 'FT_Renderer FT_LibraryRec_::cur_renderer' offset changed from 2496 to 2368 (by 128 bits)
 'FT_Module FT_LibraryRec_::auto_hinter' offset changed from 2560 to 2432 (by 128 bits)
 'FT_Byte* FT_LibraryRec_::raster_pool' offset changed from 2624 to 2496 (by 128 bits)
 'FT_ULong FT_LibraryRec_::raster_pool_size' offset changed from 2688 to 2560 (by 128 bits)
 'FT_DebugHook_Func FT_LibraryRec_::debug_hooks[4]' offset changed from 2752 to 2624 (by 128 bits)


This would indicate to me that this changes are caused by the deletion of the member "generic". But if there would be another change, I would see that in change of the relative change more easily.

Feel free to close this with resolution UPSTREAM (I don't have an account on sourceware.org).

Comment 1 Dodji Seketeli 2016-11-30 13:19:49 UTC
I opened upstream bug https://sourceware.org/bugzilla/show_bug.cgi?id=20887 to track this.

Thank you very much for filing this RFE!

Comment 2 Dodji Seketeli 2016-12-02 21:27:11 UTC
This has been implemented upstream in the master branch of the git repository.  It should be available in the upcoming 1.0.rc7 release.


Note You need to log in before you can comment on or make changes to this bug.