Bug 1382715 - [RFE] Always validate the provisioning template when it is edited
Summary: [RFE] Always validate the provisioning template when it is edited
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Provisioning Templates
Version: 6.2.2
Hardware: Unspecified
OS: Unspecified
medium
medium vote
Target Milestone: Unspecified
Assignee: satellite6-bugs
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-07 13:31 UTC by sthirugn@redhat.com
Modified: 2021-06-10 11:38 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-07-19 08:49:09 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description sthirugn@redhat.com 2016-10-07 13:31:39 UTC
Description of problem:
When provisioning template is handedited, there can be multiple sources of errors.
1. safemode rendering issue - if the erb script being used is not approved for safemode rendering
2. referred snippet not found - If the snippet referred in the template is not found or misspelt
3. Any typos
But currently, there is no validation being done in the provisioning template.  The user has to click on Preview manually to review the changes which is not that intuitive.

Version-Release number of selected component (if applicable):
satellite-6.2.2-1.1.el7sat.noarch

How reproducible:
Always

Steps to Reproduce:
1. Go to Hosts -> Provisioning Templates -> hand edit any template with any typos or referring invalid snippet or adding a code which is not supported in safemode rendering.
2. Click submit

Actual results:
No error message shown to the user.  

The user has to manually click on Preview of the Provisioning template to review the changes.

Expected results:
Whenever Provisioning Template is handedited, clicking on Submit should trigger automatic validation/preview of the template to make sure that there are no obvious errors.  I know that we cannot capture 100% of the errors using this method, but the basic errors like typos, missed snippets, safemode methods can be captured which will save plenty of time while troubleshooting.

Additional info:

Comment 1 Marek Hulan 2016-10-27 14:29:30 UTC
I'm afraid this is not possible at the moment, please see bz 1382715 for reasoning.

Comment 2 Matt Ruzicka 2016-12-28 14:34:30 UTC
Appears the discussion may actually be taking place in bz 1382712 .

Comment 3 Marek Hulan 2017-01-02 14:24:46 UTC
Correct, sorry for the wrong BZ number

Comment 4 Lukas Zapletal 2017-07-19 08:49:09 UTC
Template errors were vastly improved recently in 6.3, there is a new feature Template check, templates are verified when a host is entering build mode via "Review build status for xyz" modal dialog.

They are not checked when you edit them, that's not possible technically. There is a way to preview them, but error reporting will be the same (little bit unclear to the user).

I am closing this, we will unlikely be able to improve error reporting in preview mode, because the output is text/plain (it has to be it's 1:1 preview).


Note You need to log in before you can comment on or make changes to this bug.