1382987 – Review Request: python-flask-admin - Simple and extensible admin interface framework for Flask

Bug 1382987 - Review Request: python-flask-admin - Simple and extensible admin interface framework for Flask

Summary: Review Request: python-flask-admin - Simple and extensible admin interface fr...

Keywords:
Status:	CLOSED RAWHIDE
Alias:	None
Product:	Fedora
Classification:	Fedora
Component:	Package Review
Sub Component:
Version:	rawhide
Hardware:	All
OS:	Linux
Priority:	medium
Severity:	medium
Target Milestone:	---
Assignee:	Kevin Fenzi
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2016-10-08 21:50 UTC by Patrick Uiterwijk
Modified:	2016-10-09 20:04 UTC (History)
CC List:	2 users (show)
Fixed In Version:
Clone Of:
Environment:
Last Closed:	2016-10-09 20:04:57 UTC
Type:	---
Embargoed:
Dependent Products:
Flags:	kevin: fedora-review+

Attachments	(Terms of Use)

Description Patrick Uiterwijk 2016-10-08 21:50:17 UTC

Spec URL: https://puiterwijk.fedorapeople.org/python-flask-admin.spec
SRPM URL: https://puiterwijk.fedorapeople.org/python-flask-admin-1.4.2-1.fc26.src.rpm
Description: 
Flask-Admin is advanced, extensible and simple to use administrative interface
building extension for Flask framework.                                       
                                                                              
It comes with batteries included: model scaffolding for SQLAlchemy,           
MongoEngine, MongoDB and Peewee ORMs, simple file management interface        
and a lot of usage samples.                                                   
                                                                              
You're not limited by the default functionality - instead of providing simple 
scaffolding for the ORM models, Flask-Admin provides tools that can be used to
construct administrative interfaces of any complexity, using a consistent look
and feel.                                                                     

Fedora Account System Username: puiterwijk
Rawhide koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16004681

This is a unretire review.

Comment 1 Kevin Fenzi 2016-10-08 21:51:03 UTC

I'll review this. Look for a full review later...

Comment 2 Kevin Fenzi 2016-10-09 18:05:42 UTC

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
* There are some un-owned translation directories.

* Can you check if the tests still cannot be run due to needing mongodb?

* There's a fair bit of rpmlint complaints. Might be nice to fix the easy
ones there (just chmod 644 on html files, etc).

I don't see any other blockers, and you can fix those before import. 
This package is APPROVED.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Cannot run licensecheck: Command 'licensecheck -r /var/lib/mock
     /fedora-rawhide-x86_64/root/builddir/build/BUILD/flask-admin-1.4.2'
     returned non-zero exit status 25
[x]: License file installed when any subpackage combination is installed.
[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib/python3.5/site-
     packages/flask_admin/translations/sr/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/ko/LC_MESSAGES,
     /usr/lib/python2.7/site-packages/flask_admin/translations/uk,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/fa/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/vi/LC_MESSAGES,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/ja/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/sk/LC_MESSAGES,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/pa/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/en, /usr/lib/python2.7/site-
     packages/flask_admin/translations/el, /usr/lib/python2.7/site-
     packages/flask_admin/translations/zh_Hant_TW, /usr/lib/python3.5/site-
     packages/flask_admin/translations/af/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/vi, /usr/lib/python2.7/site-
     packages/flask_admin/translations/et, /usr/lib/python2.7/site-
     packages/flask_admin/translations/es, /usr/lib/python3.5/site-
     packages/flask_admin/translations/hu/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/fi, /usr/lib/python3.5/site-
     packages/flask_admin/translations/fa, /usr/lib/python3.5/site-
     packages/flask_admin/translations/no/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/fr, /usr/lib/python3.5/site-
     packages/flask_admin/translations/nl/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/ro, /usr/lib/python2.7/site-
     packages/flask_admin/translations/zh_Hans_CN, /usr/lib/python2.7/site-
     packages/flask_admin/translations/el/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/ru, /usr/lib/python3.5/site-
     packages/flask_admin/translations/ca_ES, /usr/lib/python3.5/site-
     packages/flask_admin/translations/tr, /usr/lib/python3.5/site-
     packages/flask_admin/translations/pt/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/ko, /usr/lib/python2.7/site-
     packages/flask_admin/translations/fr/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/zh_Hant_TW/LC_MESSAGES,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/pl/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/de, /usr/lib/python3.5/site-
     packages/flask_admin/translations/da, /usr/lib/python2.7/site-
     packages/flask_admin/translations/en/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/cs/LC_MESSAGES,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/hu/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/zh_Hans_CN/LC_MESSAGES,
     /usr/lib/python2.7/site-packages/flask_admin/translations/ca_ES,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/pl/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/pa, /usr/lib/python2.7/site-
     packages/flask_admin/translations/pl, /usr/lib/python2.7/site-
     packages/flask_admin/translations/ko/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/pt, /usr/lib/python3.5/site-
     packages/flask_admin/translations/pt_BR/LC_MESSAGES,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/ru/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/ja, /usr/lib/python2.7/site-
     packages/flask_admin/translations/it, /usr/lib/python2.7/site-
     packages/flask_admin/translations/zh_Hant_TW/LC_MESSAGES,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/ru/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/cs/LC_MESSAGES,
     /usr/lib/python3.5/site-packages/flask_admin/__pycache__,
     /usr/lib/python3.5/site-packages/flask_admin/translations/sk,
     /usr/lib/python3.5/site-packages/flask_admin/translations/sv,
     /usr/lib/python3.5/site-packages/flask_admin/translations/sr,
     /usr/lib/python2.7/site-packages/flask_admin/translations/fr,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/sv/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/fa, /usr/lib/python2.7/site-
     packages/flask_admin/translations/fi, /usr/lib/python3.5/site-
     packages/flask_admin/translations/da/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/vi, /usr/lib/python3.5/site-
     packages/flask_admin/translations/af, /usr/lib/python3.5/site-
     packages/flask_admin/translations/it/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/ar, /usr/lib/python2.7/site-
     packages/flask_admin/translations/ro/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/he, /usr/lib/python3.5/site-
     packages/flask_admin/translations/hu, /usr/lib/python2.7/site-
     packages/flask_admin/translations/it/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/et/LC_MESSAGES,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/el/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/tr/LC_MESSAGES,
     /usr/lib/python2.7/site-packages/flask_admin/translations/da,
     /usr/lib/python2.7/site-packages/flask_admin/translations/de,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/sr/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/sv/LC_MESSAGES,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/fi/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/zh_Hans_CN, /usr/lib/python2.7
     /site-packages/flask_admin/translations/de/LC_MESSAGES,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/es/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/af/LC_MESSAGES,
     /usr/lib/python3.5/site-packages/flask_admin/translations/nl,
     /usr/lib/python3.5/site-packages/flask_admin/translations/no,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/pt_BR/LC_MESSAGES,
     /usr/lib/python3.5/site-packages/flask_admin/translations/__pycache__,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/de/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/ja, /usr/lib/python2.7/site-
     packages/flask_admin/translations/ar/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/uk, /usr/lib/python3.5/site-
     packages/flask_admin/translations/ro, /usr/lib/python3.5/site-
     packages/flask_admin/translations/el, /usr/lib/python3.5/site-
     packages/flask_admin/translations/fi/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/en, /usr/lib/python3.5/site-
     packages/flask_admin/translations/ru, /usr/lib/python3.5/site-
     packages/flask_admin/translations/es, /usr/lib/python3.5/site-
     packages/flask_admin/translations/et, /usr/lib/python3.5/site-
     packages/flask_admin/translations/ar/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/es/LC_MESSAGES,
     /usr/lib/python2.7/site-packages/flask_admin/translations/tr,
     /usr/lib/python2.7/site-packages/flask_admin/translations/cs,
     /usr/lib/python3.5/site-packages/flask_admin/translations/cs,
     /usr/lib/python2.7/site-packages/flask_admin/translations/sk,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/zh_Hans_CN/LC_MESSAGES,
     /usr/lib/python2.7/site-packages/flask_admin/translations/sv,
     /usr/lib/python2.7/site-packages/flask_admin/translations/sr,
     /usr/lib/python3.5/site-packages/flask_admin/translations/ko,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/fr/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/ro/LC_MESSAGES,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/no/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/nl/LC_MESSAGES,
     /usr/lib/python3.5/site-packages/flask_admin/translations/pa,
     /usr/lib/python2.7/site-packages/flask_admin/translations/hu,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/uk/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/tr/LC_MESSAGES,
     /usr/lib/python3.5/site-packages/flask_admin/translations/pl,
     /usr/lib/python3.5/site-packages/flask_admin/translations/pt,
     /usr/lib/python2.7/site-packages/flask_admin/translations/he,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/et/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/ar, /usr/lib/python2.7/site-
     packages/flask_admin/translations/pt_BR, /usr/lib/python2.7/site-
     packages/flask_admin/translations/ca_ES/LC_MESSAGES,
     /usr/lib/python2.7/site-packages/flask_admin/translations/af,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/ja/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/vi/LC_MESSAGES,
     /usr/lib/python3.5/site-packages/flask_admin/translations/it,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/fa/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/uk/LC_MESSAGES,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/pa/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/sk/LC_MESSAGES,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/ca_ES/LC_MESSAGES,
     /usr/lib/python2.7/site-packages/flask_admin/translations/no,
     /usr/lib/python2.7/site-packages/flask_admin/translations/nl,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/en/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/zh_Hant_TW, /usr/lib/python2.7
     /site-packages/flask_admin/translations/pt/LC_MESSAGES,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/he/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/pt_BR, /usr/lib/python3.5
     /site-packages/flask_admin/translations/he/LC_MESSAGES,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/da/LC_MESSAGES
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.5/site-
     packages/flask_admin/translations/sr/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/ro, /usr/lib/python2.7/site-
     packages/flask_admin/translations/da, /usr/lib/python2.7/site-
     packages/flask_admin/translations/de/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/de, /usr/lib/python2.7/site-
     packages/flask_admin/translations/sr/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/uk, /usr/lib/python3.5/site-
     packages/flask_admin/translations/fa/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/vi/LC_MESSAGES,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/ja/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/__pycache__,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/sv/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/ru, /usr/lib/python2.7/site-
     packages/flask_admin/translations/fi/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/zh_Hans_CN, /usr/lib/python3.5
     /site-packages/flask_admin/translations/fr/LC_MESSAGES,
     /usr/lib/python3.5/site-packages/flask_admin, /usr/lib/python2.7/site-
     packages/flask_admin/translations/pa/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/en, /usr/lib/python3.5/site-
     packages/flask_admin/translations, /usr/lib/python2.7/site-
     packages/flask_admin/translations/zh_Hant_TW, /usr/lib/python3.5/site-
     packages/flask_admin/translations/af/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/es/LC_MESSAGES,
     /usr/lib/python2.7/site-packages/flask_admin/translations/nl,
     /usr/lib/python3.5/site-packages/flask_admin/translations/nl,
     /usr/lib/python3.5/site-packages/flask_admin/translations/no,
     /usr/lib/python3.5/site-packages/flask_admin/translations/vi,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/pt_BR/LC_MESSAGES,
     /usr/lib/python2.7/site-packages/flask_admin/translations/et,
     /usr/lib/python2.7/site-packages/flask_admin/translations/es,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/hu/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/fi, /usr/lib/python3.5/site-
     packages/flask_admin/translations/de/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/fa, /usr/lib/python3.5/site-
     packages/flask_admin/translations/no/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/fr, /usr/lib/python2.7/site-
     packages/flask_admin/translations/ja, /usr/lib/python3.5/site-
     packages/flask_admin/translations/nl/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/ar/LC_MESSAGES,
     /usr/lib/python3.5/site-packages/flask_admin/translations/uk,
     /usr/lib/python2.7/site-packages/flask_admin/translations/ro,
     /usr/lib/python2.7/site-packages/flask_admin/translations/zh_Hans_CN,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/ko/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/el, /usr/lib/python3.5/site-
     packages/flask_admin/translations/fi/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/en, /usr/lib/python2.7/site-
     packages/flask_admin/translations/el/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/es, /usr/lib/python3.5/site-
     packages/flask_admin/translations/et, /usr/lib/python2.7/site-
     packages/flask_admin/translations/ru, /usr/lib/python3.5/site-
     packages/flask_admin/translations/ca_ES, /usr/lib/python3.5/site-
     packages/flask_admin/translations/sr, /usr/lib/python3.5/site-
     packages/flask_admin/translations/ar/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/es/LC_MESSAGES,
     /usr/lib/python2.7/site-packages/flask_admin/translations/tr,
     /usr/lib/python3.5/site-packages/flask_admin/translations/tr,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/pt/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/ko, /usr/lib/python2.7/site-
     packages/flask_admin/translations/fr/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/cs, /usr/lib/python3.5/site-
     packages/flask_admin/translations/zh_Hant_TW/LC_MESSAGES,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/pl/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/cs, /usr/lib/python3.5/site-
     packages/flask_admin/translations/de, /usr/lib/python3.5/site-
     packages/flask_admin/translations/da, /usr/lib/python2.7/site-
     packages/flask_admin/translations/en/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/cs/LC_MESSAGES,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/hu/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/uk/LC_MESSAGES,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/zh_Hans_CN/LC_MESSAGES,
     /usr/lib/python2.7/site-packages/flask_admin/translations/sv,
     /usr/lib/python2.7/site-packages/flask_admin/translations/sr,
     /usr/lib/python2.7/site-packages/flask_admin/translations/ca_ES,
     /usr/lib/python3.5/site-packages/flask_admin/translations/ko,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/ko/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/ro/LC_MESSAGES,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/no/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/nl/LC_MESSAGES,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/pl/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/pa, /usr/lib/python2.7/site-
     packages/flask_admin/translations/pa, /usr/lib/python2.7/site-
     packages/flask_admin/translations/hu, /usr/lib/python2.7/site-
     packages/flask_admin/translations/pl, /usr/lib/python2.7/site-
     packages/flask_admin/translations/tr/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/pl, /usr/lib/python2.7/site-
     packages/flask_admin/translations/pt, /usr/lib/python3.5/site-
     packages/flask_admin/translations/pt, /usr/lib/python2.7/site-
     packages/flask_admin/translations/he, /usr/lib/python3.5/site-
     packages/flask_admin/translations/pt_BR/LC_MESSAGES,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/et/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/ar, /usr/lib/python2.7/site-
     packages/flask_admin/translations/ru/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/ja, /usr/lib/python2.7/site-
     packages/flask_admin/translations/pt_BR, /usr/lib/python2.7/site-
     packages/flask_admin/translations/ca_ES/LC_MESSAGES,
     /usr/lib/python2.7/site-packages/flask_admin/translations/it,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/zh_Hant_TW/LC_MESSAGES,
     /usr/lib/python2.7/site-packages/flask_admin/translations/af,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/ru/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/cs/LC_MESSAGES,
     /usr/lib/python3.5/site-packages/flask_admin/__pycache__,
     /usr/lib/python2.7/site-packages/flask_admin/translations/sk,
     /usr/lib/python3.5/site-packages/flask_admin/translations/sk,
     /usr/lib/python3.5/site-packages/flask_admin/translations/sv,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/ja/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/sk/LC_MESSAGES,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/vi/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/fr, /usr/lib/python2.7/site-
     packages/flask_admin/translations/sv/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/el, /usr/lib/python3.5/site-
     packages/flask_admin/translations/it, /usr/lib/python2.7/site-
     packages/flask_admin/translations/fa, /usr/lib/python2.7/site-
     packages/flask_admin/translations/fi, /usr/lib/python2.7/site-
     packages/flask_admin/translations/fa/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/uk/LC_MESSAGES,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/pa/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/da/LC_MESSAGES,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/ca_ES/LC_MESSAGES,
     /usr/lib/python2.7/site-packages/flask_admin/translations/vi,
     /usr/lib/python3.5/site-packages/flask_admin/translations/af,
     /usr/lib/python2.7/site-packages/flask_admin/translations/no,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/af/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/it/LC_MESSAGES,
     /usr/lib/python3.5/site-packages/flask_admin/translations/ar,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/ro/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/he, /usr/lib/python3.5/site-
     packages/flask_admin/translations/en/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/zh_Hant_TW, /usr/lib/python3.5
     /site-packages/flask_admin/translations/zh_Hans_CN/LC_MESSAGES,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/pt/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/hu, /usr/lib/python2.7/site-
     packages/flask_admin/translations/he/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/it/LC_MESSAGES,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/et/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/pt_BR, /usr/lib/python3.5
     /site-packages/flask_admin/translations/he/LC_MESSAGES,
     /usr/lib/python2.7/site-
     packages/flask_admin/translations/sk/LC_MESSAGES, /usr/lib/python2.7
     /site-packages/flask_admin/translations/da/LC_MESSAGES,
     /usr/lib/python3.5/site-
     packages/flask_admin/translations/el/LC_MESSAGES, /usr/lib/python3.5
     /site-packages/flask_admin/translations/tr/LC_MESSAGES
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
     But they are part of bootstrap handling.
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python-flask-admin-1.4.2-1.fc26.noarch.rpm
          python3-flask-admin-1.4.2-1.fc26.noarch.rpm
          python-flask-admin-1.4.2-1.fc26.src.rpm
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/vendor/x-editable/css/bootstrap3-editable.css
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/vendor/select2/LICENSE
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/admin/js/bs2_modal.js
python-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/flask_admin/static/admin/js/bs2_modal.js
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/admin/js/details_filter.js
python-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/flask_admin/static/admin/js/details_filter.js
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/vendor/x-editable/js/bootstrap3-editable.min.js
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/templates/bootstrap3/admin/model/list.html
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/templates/bootstrap3/admin/model/modals/details.html
python-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/flask_admin/templates/bootstrap3/admin/model/modals/details.html
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/templates/bootstrap2/admin/model/list.html
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/templates/bootstrap2/admin/model/modals/details.html
python-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/flask_admin/templates/bootstrap2/admin/model/modals/details.html
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/vendor/select2/select2.min.js
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/vendor/x-editable/css/bootstrap2-editable.css
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/admin/js/bs3_modal.js
python-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/flask_admin/static/admin/js/bs3_modal.js
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/vendor/x-editable/js/bootstrap2-editable.min.js
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/vendor/select2/select2.css
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/vendor/x-editable/css/bootstrap2-editable.css
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/vendor/select2/select2.css
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/vendor/x-editable/js/bootstrap2-editable.min.js
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/vendor/x-editable/css/bootstrap3-editable.css
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/vendor/select2/select2.min.js
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/templates/bootstrap2/admin/model/modals/details.html
python3-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python3.5/site-packages/flask_admin/templates/bootstrap2/admin/model/modals/details.html
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/vendor/x-editable/js/bootstrap3-editable.min.js
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/admin/js/bs3_modal.js
python3-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python3.5/site-packages/flask_admin/static/admin/js/bs3_modal.js
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/templates/bootstrap3/admin/model/list.html
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/admin/js/bs2_modal.js
python3-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python3.5/site-packages/flask_admin/static/admin/js/bs2_modal.js
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/vendor/select2/LICENSE
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/admin/js/details_filter.js
python3-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python3.5/site-packages/flask_admin/static/admin/js/details_filter.js
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/templates/bootstrap2/admin/model/list.html
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/templates/bootstrap3/admin/model/modals/details.html
python3-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python3.5/site-packages/flask_admin/templates/bootstrap3/admin/model/modals/details.html
python-flask-admin.src:80: W: mixed-use-of-spaces-and-tabs (spaces: line 80, tab: line 1)
3 packages and 0 specfiles checked; 38 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/vendor/select2/select2.min.js
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/templates/bootstrap2/admin/model/list.html
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/vendor/x-editable/js/bootstrap2-editable.min.js
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/vendor/select2/select2.css
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/vendor/x-editable/css/bootstrap3-editable.css
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/templates/bootstrap3/admin/model/modals/details.html
python-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/flask_admin/templates/bootstrap3/admin/model/modals/details.html
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/vendor/x-editable/css/bootstrap2-editable.css
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/templates/bootstrap3/admin/model/list.html
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/admin/js/bs3_modal.js
python-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/flask_admin/static/admin/js/bs3_modal.js
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/templates/bootstrap2/admin/model/modals/details.html
python-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/flask_admin/templates/bootstrap2/admin/model/modals/details.html
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/vendor/select2/LICENSE
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/vendor/x-editable/js/bootstrap3-editable.min.js
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/admin/js/bs2_modal.js
python-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/flask_admin/static/admin/js/bs2_modal.js
python-flask-admin.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/flask_admin/static/admin/js/details_filter.js
python-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python2.7/site-packages/flask_admin/static/admin/js/details_filter.js
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/vendor/x-editable/css/bootstrap3-editable.css
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/vendor/x-editable/css/bootstrap2-editable.css
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/admin/js/bs3_modal.js
python3-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python3.5/site-packages/flask_admin/static/admin/js/bs3_modal.js
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/vendor/x-editable/js/bootstrap2-editable.min.js
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/vendor/select2/LICENSE
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/vendor/x-editable/js/bootstrap3-editable.min.js
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/templates/bootstrap3/admin/model/modals/details.html
python3-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python3.5/site-packages/flask_admin/templates/bootstrap3/admin/model/modals/details.html
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/templates/bootstrap2/admin/model/modals/details.html
python3-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python3.5/site-packages/flask_admin/templates/bootstrap2/admin/model/modals/details.html
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/vendor/select2/select2.min.js
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/admin/js/details_filter.js
python3-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python3.5/site-packages/flask_admin/static/admin/js/details_filter.js
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/templates/bootstrap3/admin/model/list.html
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/vendor/select2/select2.css
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/templates/bootstrap2/admin/model/list.html
python3-flask-admin.noarch: E: script-without-shebang /usr/lib/python3.5/site-packages/flask_admin/static/admin/js/bs2_modal.js
python3-flask-admin.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python3.5/site-packages/flask_admin/static/admin/js/bs2_modal.js
2 packages and 0 specfiles checked; 38 errors, 0 warnings.



Requires
--------
python-flask-admin (rpmlib, GLIBC filtered):
    python(abi)
    python-flask
    python-wtforms

python3-flask-admin (rpmlib, GLIBC filtered):
    python(abi)
    python3-flask
    python3-wtforms



Provides
--------
python-flask-admin:
    python-flask-admin
    python2.7dist(flask-admin)
    python2dist(flask-admin)

python3-flask-admin:
    python3-flask-admin
    python3.5dist(flask-admin)
    python3dist(flask-admin)



Source checksums
----------------
https://github.com/flask-admin/flask-admin/archive/v1.4.2.tar.gz :
  CHECKSUM(SHA256) this package     : 6d5ea4d248beb96db57b46a2b344852e591b0d8f3c0fa3c01e9f1c95d2c5a39c
  CHECKSUM(SHA256) upstream package : 6d5ea4d248beb96db57b46a2b344852e591b0d8f3c0fa3c01e9f1c95d2c5a39c


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1382987
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Comment 3 Patrick Uiterwijk 2016-10-09 20:04:57 UTC

This has been re-imported. Thanks for the review!

Note You need to log in before you can comment on or make changes to this bug.