Hide Forgot
Spec URL: https://puiterwijk.fedorapeople.org/mirrormanager2.spec SRPM URL: https://puiterwijk.fedorapeople.org/mirrormanager2-0.7.3-2.fc26.src.rpm Description: MirrorManager keeps track of the public and private mirrors, that carry Fedora, EPEL, and RHEL content. It is used by the Fedora infrastructure as well as rpmfusion.org, a third-party repository. It automatically selects the “best” mirror for a given user based on a set of fallback heuristics (such as network, country or continent). This depends on BZ1382987 for rawhide/f24. f23 koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16004968 epel7 koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16004988 Fedora Account System Username: puiterwijk
I'll review this. Look for a full review soon...
For newer Fedora your BuildRequires: systemd-devel doesn't work... it should just be 'systemd' there. Can you adjust the spec for that? For some reason koji seems to pull it in, but local mock here doesn't.
Updated spec and srpm by just replacing systemd-devel with systemd. Rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16019711
Some notes: * The conditional on the python-sqlalchemy BuildRequires and Requires is redundant, as "0%{?rhel} == 6" implies both the variable's existence and the value must be "6". I suggest simplifying it to "%if 0%{?rhel} == 6". * The %python_sitelib macro definition is unnecessary and can be stripped. * Add "python-srpm-macros" and "python2-rpm-macros" as BuildRequires (for %{?rhel} builds only) so you can use the standard Fedora %py2_build, %py2_install, and %python2_sitelib macros. That brings it more in-line with current packaging practices. These macros are available for EL6+ through these packages. Fedora pulls them in through the python{2,3}-devel subpackage automatically. * Remove the "rm -rf $RPM_BUILD_ROOT" command in %install, as it's not needed. * Using "%{buildroot}" is preferred over "$RPM_BUILD_ROOT". * If you're going to "Requires: %{name}-lib" be constrained by the same version, you might as well tighten it to %{version}-%{release}, to prevent issues when patches might affect that part. Also, using "==" there is misleading, as it's not a comparison, but an assignment. Use "=".
Fixed those remarks except for %{buildroot} vs $RPM_BUILD_ROOT, as that's personal preference.
The URL and Source0 are wrong for this package. From what I can tell, this would be valid for this package: URL: https://github.com/fedora-infra/mirrormanager2 Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz Please fix to valid paths where the sources can be retrieved.
URL and source updated
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines ignore, it's because python-admin-flask wasn't back in at the time of review. - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros Pick the one you prefer? :) - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text Mark COPYING as %license - Note: No known owner of /usr/share/mirrormanager2 Note: Directories without known owners: /etc/httpd, /etc/logrotate.d, /etc/httpd/conf.d, /usr/share/mirrormanager2, /usr/lib/python2.7/site- packages/mirrormanager2, /usr/lib/tmpfiles.d Fix ownership [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /etc/mirrormanager-client (mirrormanager-client), /etc/mirrormanager(mirrormanager), /var/log/mirrormanager/crawler(mirrormanager), /var/lock/mirrormanager(mirrormanager), /var/lib/mirrormanager(mirrormanager), /var/run/mirrormanager(mirrormanager), /var/log/mirrormanager(mirrormanager) We need to remember to retire mirrormanager. - [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mirrormanager2-lib , mirrormanager2-mirrorlist , mirrormanager2-crawler , mirrormanager2-backend , mirrormanager2-client , mirrormanager2-statistics Should mirrorlist/crawler/client at least require lib? - Theres a number of rpmlint issues, might be nice to clean some up. Nothing particularly blocking in there however. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "*No copyright* GPL (v2)", "Unknown or generated". 304 files have unknown license. Detailed output of licensecheck in /home/fedora/kevin/1382989-mirrormanager2/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/mirrormanager2 [!]: Package must own all directories that it creates. Note: Directories without known owners: /etc/httpd, /etc/logrotate.d, /etc/httpd/conf.d, /usr/share/mirrormanager2, /usr/lib/python2.7/site- packages/mirrormanager2, /usr/lib/tmpfiles.d [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /etc/mirrormanager-client (mirrormanager-client), /etc/mirrormanager(mirrormanager), /var/log/mirrormanager/crawler(mirrormanager), /var/lock/mirrormanager(mirrormanager), /var/lib/mirrormanager(mirrormanager), /var/run/mirrormanager(mirrormanager), /var/log/mirrormanager(mirrormanager) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 307200 bytes in 15 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) missing? Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://fedorahosted.org/releases/m/i/mirrormanager/mirrormanager2-0.7.3.tar.gz See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mirrormanager2-lib , mirrormanager2-mirrorlist , mirrormanager2-crawler , mirrormanager2-backend , mirrormanager2-client , mirrormanager2-statistics [x]: Package functions as described. [x]: Latest version is packaged. [x]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Packages should try to preserve timestamps of original installed files. [x]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.2.21 starting (python version = 3.5.2)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata Mock Version: 1.2.21 INFO: Mock Version: 1.2.21 Finish: chroot init INFO: installing package(s): /home/fedora/kevin/1382989-mirrormanager2/results/mirrormanager2-crawler-0.7.3-2.fc26.noarch.rpm /home/fedora/kevin/1382989-mirrormanager2/results/mirrormanager2-lib-0.7.3-2.fc26.noarch.rpm /home/fedora/kevin/1382989-mirrormanager2/results/mirrormanager2-backend-0.7.3-2.fc26.noarch.rpm /home/fedora/kevin/1382989-mirrormanager2/results/mirrormanager2-mirrorlist-0.7.3-2.fc26.noarch.rpm /home/fedora/kevin/1382989-mirrormanager2/results/mirrormanager2-client-0.7.3-2.fc26.noarch.rpm /home/fedora/kevin/1382989-mirrormanager2/results/mirrormanager2-0.7.3-2.fc26.noarch.rpm /home/fedora/kevin/1382989-mirrormanager2/results/mirrormanager2-statistics-0.7.3-2.fc26.noarch.rpm ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 26 --disableplugin=local --setopt=deltarpm=false install /home/fedora/kevin/1382989-mirrormanager2/results/mirrormanager2-crawler-0.7.3-2.fc26.noarch.rpm /home/fedora/kevin/1382989-mirrormanager2/results/mirrormanager2-lib-0.7.3-2.fc26.noarch.rpm /home/fedora/kevin/1382989-mirrormanager2/results/mirrormanager2-backend-0.7.3-2.fc26.noarch.rpm /home/fedora/kevin/1382989-mirrormanager2/results/mirrormanager2-mirrorlist-0.7.3-2.fc26.noarch.rpm /home/fedora/kevin/1382989-mirrormanager2/results/mirrormanager2-client-0.7.3-2.fc26.noarch.rpm /home/fedora/kevin/1382989-mirrormanager2/results/mirrormanager2-0.7.3-2.fc26.noarch.rpm /home/fedora/kevin/1382989-mirrormanager2/results/mirrormanager2-statistics-0.7.3-2.fc26.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: mirrormanager2-0.7.3-2.fc26.noarch.rpm mirrormanager2-lib-0.7.3-2.fc26.noarch.rpm mirrormanager2-mirrorlist-0.7.3-2.fc26.noarch.rpm mirrormanager2-crawler-0.7.3-2.fc26.noarch.rpm mirrormanager2-backend-0.7.3-2.fc26.noarch.rpm mirrormanager2-client-0.7.3-2.fc26.noarch.rpm mirrormanager2-statistics-0.7.3-2.fc26.noarch.rpm mirrormanager2-0.7.3-2.fc26.src.rpm mirrormanager2.noarch: W: spelling-error %description -l en_US rpmfusion -> rpm fusion, rpm-fusion, suffusion mirrormanager2.noarch: E: non-executable-script /usr/share/mirrormanager2/mirrormanager2_createdb.py 644 /usr/bin/python mirrormanager2.noarch: W: non-conffile-in-etc /etc/mirrormanager/alembic.ini mirrormanager2-lib.noarch: W: no-documentation mirrormanager2-lib.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/mirrormanager2/lib/umdl.py /usr/bin/env python mirrormanager2-lib.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/mirrormanager2/lib/umdl.py 644 /usr/bin/env python mirrormanager2-mirrorlist.noarch: W: spelling-error Summary(en_US) dnf -> def, inf, DNA mirrormanager2-mirrorlist.noarch: W: spelling-error %description -l en_US dnf -> def, inf, DNA mirrormanager2-mirrorlist.noarch: W: no-documentation mirrormanager2-mirrorlist.noarch: E: non-executable-script /usr/share/mirrormanager2/mirrorlist_client.wsgi 644 /usr/bin/python mirrormanager2-mirrorlist.noarch: E: non-executable-script /usr/share/mirrormanager2/mirrorlist_server.py 644 /usr/bin/python mirrormanager2-mirrorlist.noarch: W: non-standard-uid /var/run/mirrormanager mirrormanager mirrormanager2-mirrorlist.noarch: W: non-standard-gid /var/run/mirrormanager mirrormanager mirrormanager2-mirrorlist.noarch: E: dir-or-file-in-var-run /var/run/mirrormanager mirrormanager2-mirrorlist.noarch: W: non-standard-uid /var/lib/mirrormanager mirrormanager mirrormanager2-mirrorlist.noarch: W: non-standard-gid /var/lib/mirrormanager mirrormanager mirrormanager2-crawler.noarch: W: no-documentation mirrormanager2-crawler.noarch: W: non-standard-uid /var/lib/mirrormanager mirrormanager mirrormanager2-crawler.noarch: W: non-standard-gid /var/lib/mirrormanager mirrormanager mirrormanager2-crawler.noarch: W: non-standard-uid /var/log/mirrormanager mirrormanager mirrormanager2-crawler.noarch: W: non-standard-gid /var/log/mirrormanager mirrormanager mirrormanager2-crawler.noarch: E: incoherent-logrotate-file /etc/logrotate.d/mm2_crawler mirrormanager2-crawler.noarch: W: non-standard-uid /var/log/mirrormanager/crawler mirrormanager mirrormanager2-crawler.noarch: W: non-standard-gid /var/log/mirrormanager/crawler mirrormanager mirrormanager2-crawler.noarch: W: no-manual-page-for-binary mm2_crawler mirrormanager2-backend.noarch: W: spelling-error %description -l en_US cron -> corn, con, crone mirrormanager2-backend.noarch: W: only-non-binary-in-usr-lib mirrormanager2-backend.noarch: W: no-documentation mirrormanager2-backend.noarch: E: incoherent-logrotate-file /etc/logrotate.d/mm2_umdl mirrormanager2-backend.noarch: W: non-standard-uid /var/lock/mirrormanager mirrormanager mirrormanager2-backend.noarch: W: non-standard-gid /var/lock/mirrormanager mirrormanager mirrormanager2-backend.noarch: E: dir-or-file-in-var-lock /var/lock/mirrormanager mirrormanager2-backend.noarch: W: non-standard-uid /var/run/mirrormanager mirrormanager mirrormanager2-backend.noarch: W: non-standard-gid /var/run/mirrormanager mirrormanager mirrormanager2-backend.noarch: E: dir-or-file-in-var-run /var/run/mirrormanager mirrormanager2-backend.noarch: W: non-standard-uid /var/lib/mirrormanager mirrormanager mirrormanager2-backend.noarch: W: non-standard-gid /var/lib/mirrormanager mirrormanager mirrormanager2-backend.noarch: W: non-standard-uid /var/log/mirrormanager mirrormanager mirrormanager2-backend.noarch: W: non-standard-gid /var/log/mirrormanager mirrormanager mirrormanager2-backend.noarch: W: no-manual-page-for-binary mm2_move-devel-to-release mirrormanager2-backend.noarch: W: no-manual-page-for-binary mm2_upgrade-install-repo mirrormanager2-backend.noarch: W: no-manual-page-for-binary mm2_umdl2 mirrormanager2-backend.noarch: W: no-manual-page-for-binary mm2_update-mirrorlist-server mirrormanager2-backend.noarch: W: no-manual-page-for-binary mm2_emergency-expire-repo mirrormanager2-backend.noarch: W: no-manual-page-for-binary mm2_get_global_netblocks mirrormanager2-backend.noarch: W: no-manual-page-for-binary mm2_update-EC2-netblocks mirrormanager2-backend.noarch: W: no-manual-page-for-binary mm2_move-to-archive mirrormanager2-backend.noarch: W: no-manual-page-for-binary mm2_update-master-directory-list mirrormanager2-backend.noarch: W: no-manual-page-for-binary mm2_create_install_repo mirrormanager2-backend.noarch: W: no-manual-page-for-binary mm2_get_internet2_netblocks mirrormanager2-backend.noarch: W: no-manual-page-for-binary mm2_refresh_mirrorlist_cache mirrormanager2-client.noarch: W: no-documentation mirrormanager2-client.noarch: W: no-manual-page-for-binary report_mirror mirrormanager2-statistics.noarch: W: spelling-error %description -l en_US mirrorlist -> mirror list, mirror-list, moralist mirrormanager2-statistics.noarch: W: spelling-error %description -l en_US matplotlib -> diplomatic mirrormanager2-statistics.noarch: W: no-documentation mirrormanager2-statistics.noarch: W: no-manual-page-for-binary mirrorlist_statistics mirrormanager2-statistics.noarch: W: no-manual-page-for-binary mm2_generate-worldmap mirrormanager2-statistics.noarch: W: no-manual-page-for-binary mm2_propagation mirrormanager2.src: W: spelling-error %description -l en_US rpmfusion -> rpm fusion, rpm-fusion, suffusion mirrormanager2.src: W: invalid-url Source0: https://fedorahosted.org/releases/m/i/mirrormanager/mirrormanager2-0.7.3.tar.gz HTTP Error 404: Not Found 8 packages and 0 specfiles checked; 10 errors, 51 warnings. Requires -------- mirrormanager2-backend (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/bin/perl /usr/bin/python2 config(mirrormanager2-backend) mirrormanager2-lib shadow-utils mirrormanager2-statistics (rpmlib, GLIBC filtered): /usr/bin/python2 mirrormanager2-lib python-GeoIP python-basemap python-matplotlib mirrormanager2-lib (rpmlib, GLIBC filtered): python(abi) python-IPy python-dns python-sqlalchemy mirrormanager2-mirrorlist (rpmlib, GLIBC filtered): /bin/sh config(mirrormanager2-mirrorlist) py-radix python-GeoIP python-IPy python-webob shadow-utils systemd mirrormanager2 (rpmlib, GLIBC filtered): config(mirrormanager2) mirrormanager2-lib mod_wsgi python(abi) python-alembic python-fedora python-fedora-flask python-flask python-flask-admin python-flask-wtf python-flask-xml-rpc python-psutil python-setuptools python-wtforms mirrormanager2-crawler (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python2 config(mirrormanager2-crawler) mirrormanager2-lib python-GeoIP shadow-utils mirrormanager2-client (rpmlib, GLIBC filtered): /usr/bin/python2 config(mirrormanager2-client) Provides -------- mirrormanager2-backend: config(mirrormanager2-backend) mirrormanager2-backend mirrormanager2-statistics: mirrormanager2-statistics mirrormanager2-lib: mirrormanager2-lib mirrormanager2-mirrorlist: config(mirrormanager2-mirrorlist) mirrormanager2-mirrorlist mirrormanager2: config(mirrormanager2) mirrormanager2 python2.7dist(mirrormanager2) python2dist(mirrormanager2) mirrormanager2-crawler: config(mirrormanager2-crawler) mirrormanager2-crawler mirrormanager2-client: config(mirrormanager2-client) mirrormanager2-client Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1382989 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api, Perl Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Fixed your remarks. new Spec URL: https://puiterwijk.fedorapeople.org/mirrormanager2.spec new SRPM URL: https://puiterwijk.fedorapeople.org/mirrormanager2-0.7.3-3.fc26.src.rpm
Regarding client, crawler or list needing -lib: no. -lib is only for things that directly communicate with the database, meaning the backend and the frontend.
Thanks. The only issue I see left is that you should likely move the license files to the -filesystem subpackge. That way they always get installed no matter what subset of the packages you install. ;) If you could fix that before import that would be great. This package is APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/mirrormanager2
mirrormanager2-0.7.3-4.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.