Bug 1383138 - [platformmanagement_public_508]Can't trigger deploy by manual when the first build completed with automatic=false in ICT
Summary: [platformmanagement_public_508]Can't trigger deploy by manual when the first ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OKD
Classification: Red Hat
Component: Deployments
Version: 3.x
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Michail Kargakis
QA Contact: zhou ying
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-10 03:13 UTC by zhou ying
Modified: 2016-12-09 21:52 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-12-09 21:52:24 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description zhou ying 2016-10-10 03:13:07 UTC 
Description of problem:
Create app with automatic=false in ICT, after  the first build completed, use 'oc deploy dc/dcname' try to tigger deployment, will meet Error from server: cannot trigger a deployment for "ruby-ex" because it contains unresolved images

Version-Release number of selected component (if applicable):
oc v1.4.0-alpha.0+e76e0e8
kubernetes v1.4.0+776c994
features: Basic-Auth GSSAPI Kerberos SPNEGO

openshift v1.4.0-alpha.0+e76e0e8
kubernetes v1.4.0+776c994

How reproducible:
always

Steps to Reproduce:
1. Login OpenShift and create project;
2. Use command to create app:
   `oc new-app centos/ruby-22-centos7~https://github.com/openshift/ruby-ex.git`
3. Edit the dc with automatic=false in ICT;
4. After the first build completed, check the dc;
5. Try to trigger deploy by command:
  `oc deploy dc/ruby-ex --latest`



Actual results:
4. No update image info for the dc;
5. Can't trigger deployment by manual;
[zhouy@zhouy ~]$ oc deploy ruby-ex --latest
Error from server: cannot trigger a deployment for "ruby-ex" because it contains unresolved images


Expected results:
4. Should update image info to "config.Spec.Triggers[0].ImageChangeParams.LastTriggeredImage"
5. Could trigger deployment by manual command: `oc deploy dc/ruby-ex --latest`


Additional info:
Comment 1 Michail Kargakis 2016-10-10 10:12:30 UTC 
Can you try with `oc rollout latest`? `oc deploy --latest` cannot update images in the pod template, it just redeploys what you have. Since we started using the instantiate endpoint in `deploy --latest` it can predict now that your deployment won't be deployed.
Comment 2 zhou ying 2016-10-11 05:50:42 UTC 
It's better to change the prompt message then guide user to use 'oc rollout latest' command .
Comment 3 openshift-github-bot 2016-10-14 11:53:28 UTC 
Commit pushed to master at https://github.com/openshift/origin

https://github.com/openshift/origin/commit/02a2d6265b90cec5f1378ec6cd72e1d0ae1b63e3
Bug 1383138: suggest 'rollout latest' if 'deploy --latest' returns a bad request
Comment 4 zhou ying 2016-10-17 06:20:32 UTC 
Confirmed with latest origin, the issue has fixed:
openshift version
openshift v1.4.0-alpha.0+2142bdb
kubernetes v1.4.0+776c994
etcd 3.1.0-alpha.1


oc deploy ruby-ex --latest
error: cannot trigger a deployment for "ruby-ex" because it contains unresolved images - try 'oc rollout latest dc/ruby-ex'
Note You need to log in before you can comment on or make changes to this bug.