Hide Forgot
Based on: https://trello.com/c/DSwwizwP/74-3-install-atomic-openshift-install-should-only-output-relevant-information
Ready for QE review. The changes are mostly version number bumps to make the install docs applicable for the 3.4 release, but it also includes new steps for the excluder packages. Some other minor changes too. PR for the changes is https://github.com/openshift/openshift-docs/pull/3406. Please see the following preview builds: http://file.rdu.redhat.com/~adellape/121616/install34/install_config/install/prerequisites.html http://file.rdu.redhat.com/~adellape/121616/install34/install_config/install/host_preparation.html http://file.rdu.redhat.com/~adellape/121616/install34/install_config/install/rpm_vs_containerized.html http://file.rdu.redhat.com/~adellape/121616/install34/install_config/install/quick_install.html http://file.rdu.redhat.com/~adellape/121616/install34/install_config/install/advanced_install.html http://file.rdu.redhat.com/~adellape/121616/install34/install_config/install/disconnected_install.html http://file.rdu.redhat.com/~adellape/121616/install34/install_config/install/stand_alone_registry.html Thank you!
For quick_install.html: 1, about “Example 1. Installation Configuration File Specification”,it should be OpenShift Container Platform 3.4 instead of OpenShift Container Platform 3.3 in note-1. 2, about "Uninstalling OpenShift Container Platform", it should note user about uninstall that run this command need the configuration file, which located at ~/.config/openshift/installer.cfg.yml by default or use -c option to specify the file path.
For stand_alone_registry.html: I reviewed quick install part. About "Quick Installation for Stand-alone Registries", the variant choice does not display version now, which should be following: Which variant would you like to install? (1) OpenShift Container Platform (2) Registry Choose a variant from above: [1]:
@alex Above listed docs seems not related with card https://trello.com/c/DSwwizwP/74-3-install-atomic-openshift-install-should-only-output-relevant-information, and did not include new steps for the excluder packages.
As far as I know, OCP-3.4 will only support docker-1.12, and RHEL-7.3.x, AH-7.3.x , RHEL-7.2.x, but not support AH-7.2.x and RHEL-7.1.x. That means, RHEL Atomic Host 7.2.6 is not in our supported list, the statement in [1] is wrong. Another issue is docker version mentioned in [2], currently docker version is already bumped to 1.12.5, 1.12.3 is never released. So it should be corrected. Suggest do not install a specific version of docker in yum command, only install docker. Then ask user to confirm latest 1.12 docker is installed. [1]: https://github.com/openshift/openshift-docs/pull/3406/files#diff-64d702b7a9085eb7d6af6e17d7a96469R32 [2]: https://github.com/openshift/openshift-docs/pull/3406/files#diff-64d702b7a9085eb7d6af6e17d7a96469R181 And base the above comment 5, 6, 7, assign back this bug.
Thank you for reviewing! I've made edits (commit is https://github.com/openshift/openshift-docs/pull/3406/commits/96db726f6b66e72f76ff2a84c546e603e1ffbca5) and updated the preview build. Comments inline below: (In reply to liujia from comment #5) > For quick_install.html: > 1, about “Example 1. Installation Configuration File Specification”,it > should be OpenShift Container Platform 3.4 instead of OpenShift Container > Platform 3.3 in note-1. I had left this as 3.3 intentionally here because that change happened in 3.3. > 2, about "Uninstalling OpenShift Container Platform", it should note user > about uninstall that run this command need the configuration file, which > located at ~/.config/openshift/installer.cfg.yml by default or use -c option > to specify the file path. Updated: http://file.rdu.redhat.com/~adellape/121616/install34/install_config/install/quick_install.html#uninstalling-quick (In reply to liujia from comment #6) > For stand_alone_registry.html: > > I reviewed quick install part. About "Quick Installation for Stand-alone > Registries", the variant choice does not display version now, which should > be following: > > Which variant would you like to install? > > > (1) OpenShift Container Platform > (2) Registry > > Choose a variant from above: [1]: Updated: http://file.rdu.redhat.com/~adellape/121616/install34/install_config/install/stand_alone_registry.html#registry-quick-installation (In reply to liujia from comment #7) > @alex > Above listed docs seems not related with card > https://trello.com/c/DSwwizwP/74-3-install-atomic-openshift-install-should- > only-output-relevant-information, and did not include new steps for the > excluder packages. Sorry, looks like I didn't push the commit that had the excluder steps in it. The new steps should be there now: http://file.rdu.redhat.com/~adellape/121616/install34/install_config/install/host_preparation.html#installing-base-packages And for https://trello.com/c/DSwwizwP/74-3-install-atomic-openshift-install-should-only-output-relevant-information, see my comment 3. (In reply to Johnny Liu from comment #8) > As far as I know, OCP-3.4 will only support docker-1.12, and RHEL-7.3.x, > AH-7.3.x , RHEL-7.2.x, but not support AH-7.2.x and RHEL-7.1.x. > > That means, RHEL Atomic Host 7.2.6 is not in our supported list, the > statement in [1] is wrong. Updated to more specifically note AH-7.3.2: http://file.rdu.redhat.com/~adellape/121616/install34/install_config/install/host_preparation.html#software-prerequisites http://file.rdu.redhat.com/~adellape/121616/install34/install_config/install/prerequisites.html#hardware > > Another issue is docker version mentioned in [2], currently docker version > is already bumped to 1.12.5, 1.12.3 is never released. So it should be > corrected. Suggest do not install a specific version of docker in yum > command, only install docker. Then ask user to confirm latest 1.12 docker is > installed. We used to need to specify the exact version number, but now that we have the excluder packages, you're right, we don't! I confirmed with tdawson and updated step 1 here: http://file.rdu.redhat.com/~adellape/121616/install34/install_config/install/host_preparation.html#installing-docker Thanks again!
All updated parts about comment 5, 6, 7 looks good to me now, leaving the rest to Johnny.
The update for my comment looks good to me, so move it to "verified".
Thanks!
Commit pushed to master at https://github.com/openshift/openshift-docs https://github.com/openshift/openshift-docs/commit/13b3efe74653e22ff18a89e79f59ef5bbc7c6255 Merge pull request #3406 from adellape/install34 Bug 1383276: Updates to install docs for 3.4