Spec URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-Flask-APScheduler.spec SRPM URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-Flask-APScheduler-1.5.0-1.fc24.src.rpm Description: Flask-APScheduler is a Flask extension which adds support for the APScheduler. Fedora Account System Username: hvad
Please extend the %description... Lowercase name, please [https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#General_Naming]. The same comments about repeated %description and Summary apply. .egginfo doesn't need to be deleted. %license LICENSE is missing.
Hi, I fix rpm here : Spec URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-Flask-APScheduler.spec SRPM URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-Flask-APScheduler-1.5.0-1.fc25.src.rpm LICENSE file doesn't exist. Thanks
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > Lowercase name, please > [https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging: > NamingGuidelines#General_Naming]. ? > Please extend the %description... What is APSscheduler? The description should say two or three sentences about the package, not just repeat the Summary in different word order.
Hi, I fix naming : Spec URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-flask-apscheduler.spec SRPM URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-flask-apscheduler-1.7.0-1.fc25.src.rpm Could you approve this package ? Best regard
(In reply to David Hannequin from comment #2) > Hi, > > I fix rpm here : > > Spec URL: > https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-Flask- > APScheduler.spec > > SRPM URL: > https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-Flask- > APScheduler-1.5.0-1.fc25.src.rpm > > LICENSE file doesn't exist. > > Thanks LICENSE file does exist in the repo. Add it as a Source: https://raw.githubusercontent.com/viniciuschiele/flask-apscheduler/master/LICENSE Please update the description as asked by Zbigniew and I'll finish the review.
Hi, I add license and update description : Spec URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-flask-apscheduler.spec SRPM URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-flask-apscheduler-1.7.0-1.fc26.src.rpm Best regard
Not working like this. First grab the file directly from the repo: #https://github.com/viniciuschiele/flask-apscheduler/issues/57 Source1: https://raw.githubusercontent.com/viniciuschiele/flask-apscheduler/master/LICENSE In %prep add: cp %{SOURCE1} . Then %files -n python2-flask-apscheduler %doc README.rst %license LICENSE /usr/share/licenses/python2-flask-apscheduler/LICENSE %{python2_sitelib}/flask_apscheduler %{python2_sitelib}/Flask_APScheduler-%{version}-py*egg-info %files -n python3-flask-apscheduler %doc README.rst %license LICENSE %{python3_sitelib}/flask_apscheduler %{python3_sitelib}/Flask_APScheduler-%{version}-py*egg-info
Hi, I add licence with your advise. Thank you. Spec URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-flask-apscheduler.spec SRPM URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-flask-apscheduler-1.7.0-1.fc26.src.rpm Best regard
I've proceeded with the review but I encountered problems with the tests. They need BR to run: BuildRequires: python2-setuptools BuildRequires: python2-devel BuildRequires: python2-flask BuildRequires: python2-APScheduler BuildRequires: python2-dateutil BuildRequires: python3-setuptools BuildRequires: python3-devel BuildRequires: python3-flask BuildRequires: python3-APScheduler BuildRequires: python3-dateutil Moreover the tests need apscheduler>=3.2.0: + /usr/bin/python2 setup.py test running test Searching for apscheduler>=3.2.0 Reading https://pypi.python.org/simple/apscheduler/ However the latest version available on Rawhide is 3.0.5. You need to ask the maintainer (Paul Belanger pabelanger) to update to a more recent version.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.