Bug 1384643 - If "openstack overcloud deploy --neutron-disable-tunneling" arg used, tunneling may still be set
Summary: If "openstack overcloud deploy --neutron-disable-tunneling" arg used, tunneli...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: python-tripleoclient
Version: 10.0 (Newton)
Hardware: Unspecified
OS: Unspecified
medium
high
Target Milestone: ---
: 11.0 (Ocata)
Assignee: Brent Eagles
QA Contact: Ofer Blaut
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-13 18:34 UTC by Bob Fournier
Modified: 2018-08-21 16:46 UTC (History)
8 users (show)

Fixed In Version: python-tripleoclient-6.1.1-0.20170310100058.f7196df.el7.centos
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-08-21 16:46:17 UTC
Target Upstream Version:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1704400 0 None None None 2017-07-14 14:15:11 UTC
OpenStack gerrit 483954 0 None None None 2017-07-14 14:15:46 UTC

Description Bob Fournier 2016-10-13 18:34:40 UTC
Description of problem:

The Neutron arguments in the "openstack overcloud deploy" were marked as DEPRECATED in 11/15 with this change - https://review.openstack.org/#/c/226790/ - as they could be set in heat templates.

$ openstack overcloud deploy --help
...
  --neutron-disable-tunneling
                        Disables tunneling. (DEPRECATED)

This change in OSP10 - https://review.openstack.org/#/c/335235 - removed the use of NeutronEnableTunneling from heat templates and .pp files as it was redundant. 

The neutron-disable-tunneling argument is still in the UI however.  If a user
successfully used this argument to disable tunneling in OSP 8 or OSP 9 (even though
the argument was deprecated) and then upgraded to OSP 10 and used the same deploy command, tunneling would no longer be disabled.

Some possible ways to fix this:
1. If arg set, return an Error with a message along the lines "neutron-disable-tunneling has been deprecated, set NeutronTunnelTypes to '' and NeutronNetworkType in template files"  -OR-
2. If arg set, Silently set NeutronTunnelTypes to '' in python-tripleclient to force no tunneling.  -OR-
3. Remove neutron-disable-tunneling as a valid argument so that the deploy command fails and user will have to remove the argument


Version-Release number of selected component (if applicable):
OSP10

How reproducible:
Every time.

Steps to Reproduce:
1. Run "openstack overcloud deploy" with --neutron-disable-tunneling
2. Verify vxlan (by default) tunnel has been created

Actual results:
vxlan tunnel is created.


Expected results:
No tunnel created.

Additional info:


Note You need to log in before you can comment on or make changes to this bug.