Description of problem:

The auto-generated self-hosted engine hostname is invalid if the deployment label contains more than one underscore.

Version-Release number of selected component (if applicable):

QCI-1.1-RHEL-7-20161013.t.0

How reproducible:

100%

Steps to Reproduce:
1.) Create a RHV self-hosted deployment with a name containing more than one hyphen, e.g., "rhv-self-hosted".

2.) On Engine/Hypervisor tab, see invalid auto-generated hostname:

rhv-self_hosted-rhev-engine

3.) Select a discovered host, and verify that the Next button is disabled, with no apparent errors/warnings.

4.) Verify that changing the underscores to hyphens resolves the issue.

Actual results:

Self-hosted engine hostname has invalid underscores.

Expected results:

No underscores in engine hostname, Next button is enabled after selecting a host.

Additional info:

In ./ui/app/assets/javascripts/fusor_ui/fusor-ember-cli.js, replace('_', '-') is called on the deployment label:

      if (deployment.get('isNotStarted') && _ember['default'].isEmpty(deployment.get('rhev_self_hosted_engine_hostname')) && _ember['default'].isPresent(deployment.get('label'))) {
        var dasherizedLabel = deployment.get('label').trim().replace('_', '-');
        deployment.set('rhev_self_hosted_engine_hostname', dasherizedLabel + '-rhev-engine');
      }

replace('_', '-') only replaces the first occurrence of '_'. To replace all underscores, replace(/_/g, '-') should be used instead.