Bug 1386374 - [DOCS] DROP_SYN_DURING_RESTART variable does not describe the right value.
Summary: [DOCS] DROP_SYN_DURING_RESTART variable does not describe the right value.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Documentation
Version: 3.3.0
Hardware: Unspecified
OS: Unspecified
medium
urgent
Target Milestone: ---
: ---
Assignee: Brandi Munilla
QA Contact: zhaozhanqi
Vikram Goyal
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-18 19:31 UTC by Eric Rich
Modified: 2020-06-11 13:02 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-22 15:18:48 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Eric Rich 2016-10-18 19:31:50 UTC
Document URL: https://docs.openshift.com/enterprise/3.2/install_config/install/deploy_router.html#preventing-connection-failures-during-restarts

Section Number and Name: 

https://docs.openshift.com/enterprise/3.2/install_config/install/deploy_router.html#preventing-connection-failures-during-restarts
> Configure the Router to Use iptables

Describe the issue: 

We state the following: 

> Set the option on the router deployment configuration:
>> $ oc set env dc/router -c router DROP_SYN_DURING_RESTART=true

We should describe this value to be 1 or "true" however in some vesions (3.2 we only supported '1' as a value).

Suggestions for improvement: 

Information on the variable and what can be set should be provided. 

Additional information: 

https://github.com/openshift/origin/blob/master/images/router/haproxy/reload-haproxy#L61

Comment 1 Vikram Goyal 2017-02-03 03:00:48 UTC
@Brandi - note that this for 3.2 docs onwards.

Comment 2 Brandi Munilla 2017-02-10 21:46:52 UTC
Hi Eric and Zhanqi, 

I opened PR#3723[1] to change the value from `true` to `1` in our OpenShift Container Platform 3.2 documentation. Please take a look. 

Do you think it is necessary to add the option of using either value in the other versions? If so I can add a note accordingly. 

Thanks!

[1] https://github.com/openshift/openshift-docs/pull/3723

Comment 3 zhaozhanqi 2017-02-14 09:45:02 UTC
Verified this bug 

yes, this DROP_SYN_DURING_RESTART only can be accepted '1' in 3.2. 

for 3.3 or later, it will be accepted '1' and 'true'.

Comment 4 openshift-github-bot 2017-02-14 20:50:01 UTC
Commits pushed to master at https://github.com/openshift/openshift-docs

https://github.com/openshift/openshift-docs/commit/f9b8696fb2bb29c1a68f0e3e1a0e010e36aa0228
Bug 1386374 Changed value from true to 1 in Configure the Router to Use iptables

https://github.com/openshift/openshift-docs/commit/1dd6fc36589d4db61f6ca6546321589c1c9622b0
Merge pull request #3723 from bmcelvee/BZ1386374

Bug 1386374 Changed value from `true` to `1` in Configure the Router to Use iptables


Note You need to log in before you can comment on or make changes to this bug.