Spec URL: https://abompard.fedorapeople.org/reviews/lazr.smtptest/python-lazr-smtptest.spec SRPM URL: https://abompard.fedorapeople.org/reviews/lazr.smtptest/python-lazr-smtptest-2.0.3-1.fc23.src.rpm Description: This is LAZR smtptest, a framework for testing SMTP-based applications and libraries. It provides a real, live SMTP server that you can send messages to, and from which you can read those test messages. This can be used to ensure proper operation of your applications which send email. Fedora Account System Username: abompard
No need to delete .egg-info (the guidelines say that "binary eggs" must be deleted, and this is not it). Build fails here with: ====================================================================== FAIL: Doctest: usage.rst ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/lib64/python3.5/doctest.py", line 2190, in runTest raise self.failureException(self.format_failure(new.getvalue())) AssertionError: Failed doctest test for usage.rst File "/builddir/build/BUILD/lazr.smtptest-2.0.3/lazr/smtptest/docs/usage.rst", line 0 ---------------------------------------------------------------------- File "/builddir/build/BUILD/lazr.smtptest-2.0.3/lazr/smtptest/docs/usage.rst", line 58, in usage.rst Failed example: print(message.as_string()) Differences (ndiff with -expected +actual): From: Abby Person <aperson> To: Bart Person <bperson> Subject: A test Message-ID: <aardvark> - X-Peer: 127.0.0.1:... + X-Peer: ::1:41842 X-MailFrom: aperson X-RcptTo: bperson <BLANKLINE> Hi Bart, this is a test. Looks good, but please make %check pass.
I've made these changes, thanks for the review. Spec URL: https://abompard.fedorapeople.org/reviews/lazr.smtptest/python-lazr-smtptest.spec SRPM URL: https://abompard.fedorapeople.org/reviews/lazr.smtptest/python-lazr-smtptest-2.0.3-1.fc23.src.rpm
+ latest version + package name is OK + license is acceptable (LGPLv3) + license is specified correctly + builds and install OK + provides/requires look correct + fedora-review is happy + no scriptlets + python packaging macros are used + %python_provide is used + %check passes Nice. Package is APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-lazr-smtptest
python-lazr-smtptest-2.0.3-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-54be67dd74
python-lazr-smtptest-2.0.3-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-54be67dd74
python-lazr-smtptest-2.0.3-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.