Bug 1387626 - Review Request: perl-Term-Chrome - DSL for colors and other terminal chrome
Summary: Review Request: perl-Term-Chrome - DSL for colors and other terminal chrome
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1387619
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-21 12:00 UTC by Petr Pisar
Modified: 2016-10-26 12:35 UTC (History)
2 users (show)

Fixed In Version: perl-Term-Chrome-2.00-1.fc26
Clone Of:
Environment:
Last Closed: 2016-10-26 12:35:46 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2016-10-21 12:00:58 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Term-Chrome/perl-Term-Chrome.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Term-Chrome/perl-Term-Chrome-2.00-1.fc26.src.rpm
Description:
Term::Chrome is a domain-specific language (DSL) for terminal decoration
(colors and other attributes) in Perl.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-10-26 10:32:56 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Term-Chrome-2.00-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(Carp)
      1 perl(Exporter) >= 5.57
      1 perl(Scalar::Util)
      1 perl(constant)
      1 perl(overload)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Term-Chrome-2.00-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(Term::Chrome) = 2.00
      1 perl-Term-Chrome = 2.00-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Term-Chrome*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

The package is good.
Approved.

Comment 2 Gwyn Ciesla 2016-10-26 12:16:19 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Term-Chrome

Comment 3 Petr Pisar 2016-10-26 12:35:46 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.