Bug 1387634 - Review Request: perl-Devel-Gladiator - Walk Perl's arena
Summary: Review Request: perl-Devel-Gladiator - Walk Perl's arena
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-21 12:24 UTC by Petr Pisar
Modified: 2016-10-26 08:59 UTC (History)
2 users (show)

Fixed In Version: perl-Devel-Gladiator-0.07-1.fc26
Clone Of:
Environment:
Last Closed: 2016-10-26 08:59:08 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2016-10-21 12:24:14 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Devel-Gladiator/perl-Devel-Gladiator.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Devel-Gladiator/perl-Devel-Gladiator-0.07-1.fc26.src.rpm
Description:
Devel::Gladiator iterates Perl's internal memory structures and can be used to
enumerate all the currently live SVs. This can be used to hunt leaks and to
profile memory usage.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-10-24 13:41:35 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Devel-Gladiator-0.07-1.fc26.x86_64.rpm | sort | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libperl.so.5.24()(64bit)
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(Exporter)
      1 perl(XSLoader)
      1 perl(base)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-Devel-Gladiator-0.07-1.fc26.x86_64.rpm | sort | uniq -c
      1 perl(Devel::Gladiator) = 0.07
      1 perl-Devel-Gladiator = 0.07-1.fc26
      1 perl-Devel-Gladiator(x86-64) = 0.07-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Devel-Gladiator*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

BuildRequires
- perl(PadWalker) is only optional for test (Devel-Gladiator-0.07/t/padwalker.t)
FIX: Please add build-require 'findutils' (perl-Devel-Gladiator.spec:45)


Please correct 'FIX' issue.

Otherwise the package looks good.
Approved.

Comment 2 Gwyn Ciesla 2016-10-24 14:44:07 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Devel-Gladiator

Comment 3 Petr Pisar 2016-10-26 08:59:08 UTC
Thank you for the review and the repository. I added the dependency on findutils.


Note You need to log in before you can comment on or make changes to this bug.