Bug 1387992 - [devexp_public_878]Authorization Token option displays dot when inputing token in build step of latest centos jenkin plugin
Summary: [devexp_public_878]Authorization Token option displays dot when inputing toke...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OKD
Classification: Red Hat
Component: Image
Version: 3.x
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Justin Pierce
QA Contact: Wang Haoran
URL:
Whiteboard:
Depends On:
Blocks: 1390417 1390491
TreeView+ depends on / blocked
 
Reported: 2016-10-24 07:14 UTC by wewang
Modified: 2016-12-09 21:53 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1390417 (view as bug list)
Environment:
Last Closed: 2016-12-09 21:53:18 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description wewang 2016-10-24 07:14:06 UTC
versions:
docker.io/openshift/jenkins-1-centos7  688c1f456664
OpenShift Pipeline Jenkins Plugin 1.0.26

Description of problem:
Authorization Token option displays dot when inputing token in build step of jenkins 

How reproducible:
Always

steps:
1. Create jenkins
 $ oc new-project test
 $oc policy add-role-to-user admin system:serviceaccount:test:jenkins -n test 
 $oc import-image jenkins --from='docker.io/openshift/jenkins-1-centos7' --confirm=true --insecure=true --all=true
 $oc new-app -f https://raw.githubusercontent.com/openshift/origin/master/examples/jenkins/jenkins-ephemeral-template.json # change namespace to test
2. go to jenkins website and configure build step , for example "trigger openshift build"

3. input token in Authorization Token options, display dot,not actual words 

Actual results:
input token in Authorization Token options, display dot 
Expected results:
should display what you inputs

attional info:
us card  tells jenkins verison is f60aadf3c879,but we pulled  latest image is 688c1f456664

Comment 2 Gabe Montero 2016-10-24 17:09:06 UTC
Yep, this is on purpose - Justin made a change to have the auth token field act as a password field, where the characters become dots.

Seemed like an reasonable improvement to me.

But we can certainly debate here if necessary.

Comment 3 Justin Pierce 2016-10-24 18:57:04 UTC
@wewang, the Jenkins UI now treats the OpenShift authorization tokens as typical HTML password fields. This protects the important credential from being displayed openly.

It should still contain precisely what you enter, but the value will be visibly masked.

Comment 4 wewang 2016-10-27 08:48:35 UTC
@Justin Pierce,got it,thanks for explain, in future the value will be masked with dot.


Note You need to log in before you can comment on or make changes to this bug.