Bug 1387999 - [userinterface_public_797]deployment strategy type should not be updated before saving strategy changes
Summary: [userinterface_public_797]deployment strategy type should not be updated befo...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 3.4.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Jakub Hadvig
QA Contact: Yadan Pei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-24 07:47 UTC by Yadan Pei
Modified: 2017-03-08 18:43 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: Changing deployment strategy in DC editor. Consequence: Shows that the strategy was updated. This was displayed in the editor header, right from the DC name. Fix: Remove the strategy name from the header, since it duplicate and also the strategy will change only after the change is saved. Result: If the strategy is changed the header wont indicate that the change is being saved.
Clone Of:
Environment:
Last Closed: 2017-03-08 18:34:04 UTC
Target Upstream Version:


Attachments (Terms of Use)
EnterDCEditPageFirstTime (36.40 KB, image/png)
2016-10-24 07:48 UTC, Yadan Pei
no flags Details
AfterRollingSelected (43.08 KB, image/png)
2016-10-24 07:48 UTC, Yadan Pei
no flags Details

Description Yadan Pei 2016-10-24 07:47:41 UTC
Description of problem:
During switching between deployment strategy on DC edit page, the deployment strategy type changes accordingly, even we didn't save the changes

Version-Release number of selected component (if applicable):
v3.4.0.14

How reproducible:
Always

Steps to Reproduce:
1.Create app with DC strategy is Recreate
$ oc process -f https://raw.githubusercontent.com/openshift/rails-ex/master/openshift/templates/rails-postgresql.json |oc create -f -
2.Go to Applications -> Deployments -> rails-postgresql-example page -> Actions -> Edit
3.We could see follow message on top of DC edit page
Edit Deployment Config rails-postgresql-example — Recreate Deployment Strategy
4.Select "Rolling" from Strategy Type, click "Yes" or "No" in the dialog
5.Check the message at the top of DC edit page again

Actual results:
5.Deployment Strategy is updated to Rolling
Edit Deployment Config rails-postgresql-example — Rolling Deployment Strategy

Expected results:
5. Actually, before saving the DC changes, this message should not be updated because this indicates the current deployment strategy. The correct message should still be:Edit Deployment Config rails-postgresql-example — Recreate Deployment Strategy. After we changed and saved the deployment strategy, then access edit page again ,this message should be updated to correct deployment strategy type

Additional info:

Comment 1 Yadan Pei 2016-10-24 07:48:23 UTC
Created attachment 1213355 [details]
EnterDCEditPageFirstTime

Comment 2 Yadan Pei 2016-10-24 07:48:55 UTC
Created attachment 1213356 [details]
AfterRollingSelected

Comment 3 openshift-github-bot 2016-10-24 13:22:58 UTC
Commit pushed to master at https://github.com/openshift/origin-web-console

https://github.com/openshift/origin-web-console/commit/fe74d065ea4ce32010a960a2255e137d67e3d869
Bug 1387999 - Deployment strategy type should not be updated before saving strategy changes

Comment 4 Jakub Hadvig 2016-10-31 14:53:17 UTC
@yapei we decided to remove the strategy type from the header since its redundant with the selectbox below.

Comment 5 Yadan Pei 2016-11-01 06:19:15 UTC
Checked against v3.4.0.18+ada983f

Now the strategy type is removed from DC edit page, so this issue don't exist any more, move to VERIFIED


Note You need to log in before you can comment on or make changes to this bug.