Bug 1388338 - unhandled exception when sending emails to alert recipients
Summary: unhandled exception when sending emails to alert recipients
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: setroubleshoot
Version: 7.3
Hardware: All
OS: Linux
low
low
Target Milestone: rc
: ---
Assignee: Petr Lautrbach
QA Contact: Milos Malik
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-25 07:06 UTC by Milos Malik
Modified: 2017-03-24 13:08 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1388335
Environment:
Last Closed: 2017-03-24 13:08:04 UTC
Target Upstream Version:

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Milos Malik 2016-10-25 07:06:54 UTC 
+++ This bug was initially created as a clone of Bug #1388335 +++

Description of problem:
* traceback happens when email alerts are enabled and local mail servers are down
* SELinux denials are analyzed as expected, but email alerts are not sent

Version-Release number of selected component (if applicable):
setroubleshoot-server-3.2.27.2-3.el7.x86_64
setroubleshoot-3.2.27.2-3.el7.x86_64
setroubleshoot-plugins-3.0.64-2.1.el7.noarch

How reproducible:
* always

Steps to Reproduce:
0. echo "root@localhost filter_type=never" >> /var/lib/setroubleshoot/email_alert_recipients
1. stop all local mail servers
2. trigger an SELinux denial
3. look into journal or /var/log/messages

Actual results:
Oct 25 02:49:49 unused-4-245 setroubleshoot: Exception during AVC analysis: [Errno 111] Connection refused

Expected results:
 * all exceptions are handled
Comment 1 Petr Lautrbach 2017-03-24 13:03:31 UTC 
I'd say that exceptions are handled by the code. They are caught and resent to syslog: 

```
    def run(self):
        while True:
            try:
                avc, report_receiver = self.queue.get()
                self.analyze_avc(avc, report_receiver)
            except Exception as e:
                syslog.syslog(syslog.LOG_ERR, "Exception during AVC analysis: %s" % e)
            except ValueError as e:
                syslog.syslog(syslog.LOG_ERR, "Exception during AVC analysis: %s" % e)
```


Milos, is this acceptable for you?
Comment 2 Milos Malik 2017-03-24 13:07:39 UTC 
Yes, it is.
Note You need to log in before you can comment on or make changes to this bug.