Bug 1389634 - python-gevent-1.2.2 is available
Summary: python-gevent-1.2.2 is available
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-gevent
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dan Callaghan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-28 05:23 UTC by Upstream Release Monitoring
Modified: 2017-08-17 06:42 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-08-17 06:42:39 UTC
Type: ---


Attachments (Terms of Use)
Rebase-helper rebase-helper-debug.log log file. See for details and report the eventual error to rebase-helper https://github.com/phracek/rebase-helper/issues. (5.24 KB, patch)
2016-12-24 00:12 UTC, Upstream Release Monitoring
no flags Details | Diff
Rebase-helper rebase-helper-debug.log log file. See for details and report the eventual error to rebase-helper https://github.com/phracek/rebase-helper/issues. (5.24 KB, patch)
2017-01-13 00:17 UTC, Upstream Release Monitoring
no flags Details | Diff
0001-Update-to-1.2.2-RHBZ-1389634.patch (4.40 KB, patch)
2017-06-07 04:45 UTC, Dan Callaghan
no flags Details | Diff
0001-Update-to-1.2.2-RHBZ-1389634.patch v2 (4.66 KB, patch)
2017-06-07 05:23 UTC, Dan Callaghan
no flags Details | Diff

Description Upstream Release Monitoring 2016-10-28 05:23:55 UTC
Latest upstream release: 1.2a1
Current version/release in rawhide: 1.0-2.el7
URL: http://www.gevent.org/

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring

Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.

Based on the information from anitya:  https://release-monitoring.org/project/6835/

Comment 1 Upstream Release Monitoring 2016-10-28 05:24:20 UTC
Rebase helper failed.
See logs and attachments in this bugzilla 'NoneType' object has no attribute 'get_rebasehelper_data'

Comment 2 Upstream Release Monitoring 2016-10-28 05:24:44 UTC
Failed to kick off scratch build.

cmd:  spectool -g /var/tmp/thn-Pp3ZHN/python-gevent.spec
return code:  22
stdout:
Getting https://github.com/gevent/gevent/releases/download/v1.2a1/gevent-1.2a1.tar.gz to ./gevent-1.2a1.tar.gz

stderr:
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found

Comment 3 Upstream Release Monitoring 2016-12-10 00:13:59 UTC
Latest upstream release: 1.2a2
Current version/release in rawhide: 1.0-2.el7
URL: http://www.gevent.org/

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring

Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.

Based on the information from anitya:  https://release-monitoring.org/project/6835/

Comment 4 Upstream Release Monitoring 2016-12-10 00:14:23 UTC
Rebase helper failed.
See logs and attachments in this bugzilla 'NoneType' object has no attribute 'get_rebasehelper_data'

Comment 5 Upstream Release Monitoring 2016-12-10 00:14:46 UTC
Failed to kick off scratch build.

cmd:  spectool -g /var/tmp/thn-6kGK5n/python-gevent.spec
return code:  22
stdout:
Getting https://github.com/gevent/gevent/releases/download/v1.2a2/gevent-1.2a2.tar.gz to ./gevent-1.2a2.tar.gz

stderr:
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found

Comment 6 Upstream Release Monitoring 2016-12-24 00:12:22 UTC
Latest upstream release: 1.2.0
Current version/release in rawhide: 1.0-2.el7
URL: http://www.gevent.org/

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring

Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.

Based on the information from anitya:  https://release-monitoring.org/project/6835/

Comment 7 Upstream Release Monitoring 2016-12-24 00:12:48 UTC
Patching or scratch build for python-gevent-1.0 failed.

Comment 8 Upstream Release Monitoring 2016-12-24 00:12:50 UTC
Created attachment 1235140 [details]
Rebase-helper rebase-helper-debug.log log file.
See for details and report the eventual error to rebase-helper https://github.com/phracek/rebase-helper/issues.

Comment 9 Upstream Release Monitoring 2016-12-24 00:12:52 UTC
Patches were not touched. All were applied properly

Comment 10 Upstream Release Monitoring 2017-01-13 00:16:57 UTC
Latest upstream release: 1.2.1
Current version/release in rawhide: 1.0-2.el7
URL: http://www.gevent.org/

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring

Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.

Based on the information from anitya:  https://release-monitoring.org/project/6835/

Comment 11 Upstream Release Monitoring 2017-01-13 00:17:22 UTC
Patching or scratch build for python-gevent-1.0 failed.

Comment 12 Upstream Release Monitoring 2017-01-13 00:17:25 UTC
Created attachment 1240151 [details]
Rebase-helper rebase-helper-debug.log log file.
See for details and report the eventual error to rebase-helper https://github.com/phracek/rebase-helper/issues.

Comment 13 Upstream Release Monitoring 2017-01-13 00:17:27 UTC
Patches were not touched. All were applied properly

Comment 14 Upstream Release Monitoring 2017-06-05 12:18:03 UTC
Latest upstream release: 1.2.2
Current version/release in rawhide: 1.1.2-3.fc26
URL: http://www.gevent.org/

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring

Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.

Based on the information from anitya:  https://release-monitoring.org/project/6835/

Comment 15 Upstream Release Monitoring 2017-06-05 12:18:11 UTC
An HTTP error occurred downloading the package's new Source URLs: Getting https://github.com/gevent/gevent/releases/download/v1.2.2/gevent-1.2.2.tar.gz to ./gevent-1.2.2.tar.gz

Comment 16 Dan Callaghan 2017-06-07 01:35:15 UTC
The 1.2.x series introduces some incompatibilities (we have 1.1.x currently in Fedora and EPEL).

http://www.gevent.org/changelog.html#a1-oct-27-2016

So this should go to rawhide only.

Seems like we have a few consumers of gevent in the distro now too:

$ dnf repoquery --releasever=rawhide --whatrequires 'python*-gevent'
python-gevent-socketio-0:0.3.6-4.fc26.noarch
python-mwlib-0:0.15.14-5.fc25.x86_64
python-qserve-0:0.2.8-8.fc26.noarch
python2-gevent-websocket-0:0.9.5-4.fc26.noarch
python2-parallel-ssh-0:0.91.2-4.fc26.noarch
python2-psycogreen-0:1.0-3.fc26.noarch
python2-pykka-0:1.2.1-7.fc26.noarch
python2-tinyrpc-0:0.5-4.20170523git1f38ac.fc27.noarch
python2-tinyrpc-tests-0:0.5-4.20170523git1f38ac.fc27.noarch
python2-x2go-0:0.5.0.5-1.fc27.noarch
python3-parallel-ssh-0:0.91.2-4.fc26.noarch
python3-psycogreen-0:1.0-3.fc26.noarch
python3-tinyrpc-0:0.5-4.20170523git1f38ac.fc27.noarch
python3-tinyrpc-tests-0:0.5-4.20170523git1f38ac.fc27.noarch

Comment 17 Dan Callaghan 2017-06-07 02:54:09 UTC
According to the release notes, the biggest incompatibilities are the removal of gevent.coros, gevent.corecext, and gevent.corecffi. Some rudimentary grepping (by installing all of the above packages on my rawhide box and then grepping in /usr/lib*/python*/site-packages) shows the only package which should be affected by those changes is python-mwlib. I filed bug 1459389 against python-mwlib, but that package is not a good state (it's FTBFS currently and a few releases behind upstream as well) so I don't think we need to hold up gevent for that.

There are also some subtler behavioural incompatibilities in gevent 1.2.x which might affect some callers in some edge cases. So I will send a mail to the devel list to warn people.

Comment 18 Dan Callaghan 2017-06-07 04:38:20 UTC
Upstream seem to have stopped publishing tarballs on Github, we can switch to PyPI for the source tarball instead.

It also looks like we need to explicitly disable building the CFFI backend now, by setting GEVENT_NO_CFFI_BUILD in the build environment:

https://github.com/gevent/gevent/commit/b1a878423264328aa496ff41e60ac2687aff0e1d

In our current builds of 1.1.x the CFFI backend implicitly disables itself in the build, since it requires the bundled copy of libev which we remove.

There is also a bug with gevent's setup.py where it obsessively tries to configure the bundled libev:

https://github.com/gevent/gevent/pull/979

Comment 20 Dan Callaghan 2017-06-07 04:45:54 UTC
Created attachment 1285659 [details]
0001-Update-to-1.2.2-RHBZ-1389634.patch

So this is what I have so far. It builds, but for some reason setuptools has started copying over the C extension source files into the build root, which we don't want (and causes an rpmlint error):

[...]
writing manifest file 'src/gevent.egg-info/SOURCES.txt'
copying src/gevent/_semaphore.pxd -> build/lib.linux-x86_64-3.6/gevent
copying src/gevent/ares.pyx -> build/lib.linux-x86_64-3.6/gevent
copying src/gevent/cares.pxd -> build/lib.linux-x86_64-3.6/gevent
copying src/gevent/cares_ntop.h -> build/lib.linux-x86_64-3.6/gevent
copying src/gevent/cares_pton.h -> build/lib.linux-x86_64-3.6/gevent
copying src/gevent/dnshelper.c -> build/lib.linux-x86_64-3.6/gevent
copying src/gevent/gevent._semaphore.c -> build/lib.linux-x86_64-3.6/gevent
copying src/gevent/gevent.ares.c -> build/lib.linux-x86_64-3.6/gevent
copying src/gevent/gevent.ares.h -> build/lib.linux-x86_64-3.6/gevent
copying src/gevent/python.pxd -> build/lib.linux-x86_64-3.6/gevent
copying src/gevent/libev/_corecffi_cdef.c -> build/lib.linux-x86_64-3.6/gevent/libev
copying src/gevent/libev/_corecffi_source.c -> build/lib.linux-x86_64-3.6/gevent/libev
copying src/gevent/libev/callbacks.c -> build/lib.linux-x86_64-3.6/gevent/libev
copying src/gevent/libev/callbacks.h -> build/lib.linux-x86_64-3.6/gevent/libev
copying src/gevent/libev/corecext.ppyx -> build/lib.linux-x86_64-3.6/gevent/libev
copying src/gevent/libev/corecext.pyx -> build/lib.linux-x86_64-3.6/gevent/libev
copying src/gevent/libev/gevent.corecext.c -> build/lib.linux-x86_64-3.6/gevent/libev
copying src/gevent/libev/libev.h -> build/lib.linux-x86_64-3.6/gevent/libev
copying src/gevent/libev/libev.pxd -> build/lib.linux-x86_64-3.6/gevent/libev
copying src/gevent/libev/libev_vfd.h -> build/lib.linux-x86_64-3.6/gevent/libev
copying src/gevent/libev/stathelper.c -> build/lib.linux-x86_64-3.6/gevent/libev
running build_ext
[...]

Not sure why it's doing this, but they have lots of crazy customizations imported in their setup.py so it could be due to one of those. In our previous builds this did not happen, for example:

https://kojipkgs.fedoraproject.org//packages/python-gevent/1.1.2/3.fc26/data/logs/x86_64/build.log

Comment 21 Dan Callaghan 2017-06-07 05:11:42 UTC
(In reply to Dan Callaghan from comment #20)

Ahh found it, it comes from include_package_data=True which is now set upstream in setup.py unconditionally. Even though it seems to only be there for PyPy's sake. We can just sed it back to False I think.

Comment 22 Dan Callaghan 2017-06-07 05:23:39 UTC
Created attachment 1285662 [details]
0001-Update-to-1.2.2-RHBZ-1389634.patch v2

This is the patch I will push on Friday, if no other issues come up. Scratch build for testing is here:

https://koji.fedoraproject.org/koji/taskinfo?taskID=19893195

Comment 23 Dan Callaghan 2017-08-17 06:42:39 UTC
I accidentally forgot about merging this, so I guess I have missed the boat for Fedora 27 now.

This is now built for rawhide, so it will be in Fedora 28+.

https://koji.fedoraproject.org/koji/buildinfo?buildID=956442


Note You need to log in before you can comment on or make changes to this bug.