Bug 1390353 - Support env file during application deployment
Summary: Support env file during application deployment
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: openshift-controller-manager
Version: 3.4.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: ---
Assignee: Ben Parees
QA Contact: zhou ying
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-10-31 19:19 UTC by Alfredo Quiroga
Modified: 2017-03-24 13:46 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-03-24 13:44:04 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Alfredo Quiroga 2016-10-31 19:19:46 UTC
Description of problem:

- Support env file during application deployment

For example:

https://docs.docker.com/compose/env-file/

Version-Release number of selected component (if applicable):

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Michal Fojtik 2017-03-24 09:52:25 UTC
(In reply to Alfredo Quiroga from comment #0)
> Description of problem:
> 
> - Support env file during application deployment
> 
> For example:
> 
> https://docs.docker.com/compose/env-file/
> 

Can you please provide more use-cases how you think the env-file should be used? We can't reference an 'env-file' in deployment config, however I think what you want here is the Template parameters.

Comment 2 Alfredo Quiroga 2017-03-24 12:59:44 UTC
Hi:

The example can be seen here:

https://docs.docker.com/compose/env-file/

As an additional example, today we can do the following:

oc new-app lawwton/welcome -e FOO=BAR -e HELLO=WORLD

This issue calls for the same functionality provided in compose (env-file) where we would be able to say:

oc new-app lawwton/welcome -e /tmp/my-env.properties
oc start-build ...
oc deploy ...

All of those commands should support this.

my-env.properties would contain:

# My properties
FOO=BAR
HELLO=WORLD

Hope that helps.

Thanks in advance.

Comment 3 Ben Parees 2017-03-24 13:44:04 UTC
This has been implemented.
https://docs.openshift.org/latest/dev_guide/application_lifecycle/new_app.html#specifying-environment-variables

It will be part of the OCP3.5 release which is coming soon.

Comment 4 Alfredo Quiroga 2017-03-24 13:46:33 UTC
Awesome!

Tx.


Note You need to log in before you can comment on or make changes to this bug.