Bug 1392368 - dracut.conf(5): Make it clearer that += values must end in a space if specified in multiple config files
Summary: dracut.conf(5): Make it clearer that += values must end in a space if specifi...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: dracut
Version: 7.2
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: rc
: ---
Assignee: Lukáš Nykrýn
QA Contact: qe-baseos-daemons
URL:
Whiteboard:
Depends On:
Blocks: 1298243 1420851 1801675
TreeView+ depends on / blocked
 
Reported: 2016-11-07 10:40 UTC by Stuart Auchterlonie
Modified: 2021-02-15 10:22 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-11-11 21:54:16 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description Stuart Auchterlonie 2016-11-07 10:40:05 UTC
Description of problem:

If you create multiple files to add modules into the initrd
in /etc/dracut.conf.d, each containing their own add_drivers
stanza, then the modules listed are incorrectly concatenated
together

Version-Release number of selected component (if applicable):

dracut-033-359.el7.x86_64

How reproducible:

100%

Steps to Reproduce:
1. create file /etc/dracut.conf.d/dmsnapshot.conf with contents
add_drivers+="dm-snapshot"
2. create file /etc/dracut.conf.d/isofs.conf with contents
add_drivers+="isofs"
3. run `dracut -f`


Actual results:

Fails with the following message
"
Failed to install module dm_snapshotisofs
"

You can see that the names of the 2 modules are concatenated
together without a space to delimit them.

Expected results:

Initrd correctly builds with the required modules

Additional info:

work around is to include a space " " at the end of each
add_drivers stanza so that when the strings are concatenated
they are correctly delimited.

Comment 2 Lukáš Nykrýn 2016-11-07 14:15:48 UTC
This is documented in the manpage:

add_drivers+=" <kernel modules> "
           Specify a space-separated list of kernel modules to add to the initramfs. The kernel modules have to be specified without the ".ko" suffix.

Comment 3 Stuart Auchterlonie 2016-11-07 14:40:42 UTC
It could be argued that the vmware-tools are providing
"a space-separated list of kernel modules to add...."

# cat /etc/dracut.conf.d/vmware-tools.conf
add_drivers+="vmxnet3 vmw_pvscsi"

Comment 4 Harald Hoyer 2016-11-16 13:22:25 UTC
Since these config files are sourced as shell scripts, it is not possible to fix this.

In the future we should move to arrays with:
add_drivers+=(vmxnet3 vmw_pvscsi)

but still  /etc/dracut.conf.d/vmware-tools.conf would be broken then

Comment 7 John Ruemker 2016-12-15 15:09:28 UTC
ACK. Thanks Stuart.  I've updated the subject of this bug to reflect its current focus.

Do you want to follow up on the vmware-tools aspect?

Let me know if I can assist with anything.

Thanks,
-John

Comment 14 Chris Williams 2020-11-11 21:54:16 UTC
Red Hat Enterprise Linux 7 shipped it's final minor release on September 29th, 2020. 7.9 was the last minor releases scheduled for RHEL 7.
From intial triage it does not appear the remaining Bugzillas meet the inclusion criteria for Maintenance Phase 2 and will now be closed. 

From the RHEL life cycle page:
https://access.redhat.com/support/policy/updates/errata#Maintenance_Support_2_Phase
"During Maintenance Support 2 Phase for Red Hat Enterprise Linux version 7,Red Hat defined Critical and Important impact Security Advisories (RHSAs) and selected (at Red Hat discretion) Urgent Priority Bug Fix Advisories (RHBAs) may be released as they become available."

If this BZ was closed in error and meets the above criteria please re-open it flag for 7.9.z, provide suitable business and technical justifications, and follow the process for Accelerated Fixes:
https://source.redhat.com/groups/public/pnt-cxno/pnt_customer_experience_and_operations_wiki/support_delivery_accelerated_fix_release_handbook  

Feature Requests can re-opened and moved to RHEL 8 if the desired functionality is not already present in the product. 

Please reach out to the applicable Product Experience Engineer[0] if you have any questions or concerns.  

[0] https://bugzilla.redhat.com/page.cgi?id=agile_component_mapping.html&product=Red+Hat+Enterprise+Linux+7


Note You need to log in before you can comment on or make changes to this bug.