Hide Forgot
Created attachment 1218087 [details] log with the issue Description of problem: Color syntax in log is not handling url inside quotes Version-Release number of selected component (if applicable): OpenShift Master: v3.3.0.32 Kubernetes Master: v1.3.0+52492b4 How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: see attachment, there are extra letters highlighted in blue Expected results: Additional info:
We are using the linkify filter coming from Angular which is following the RFC for what is considered a valid URL. URL paths can include quote characters. That said we have considered rolling our own version that ignores quotes because this is such a common occurrence in log output.
We use the Angular filter in most places, but for the logs specifically, we're using ansi_up linkify. Looking at the source, I think we can do better. The regex matches any non-whitespace character after the start of the URL. https://github.com/drudru/ansi_up/blob/master/ansi_up.js#L93-L97
Here's the Angular implementation: https://github.com/angular/angular.js/blob/master/src/ngSanitize/filter/linky.js#L131-L132 It's a lot more sophisticated, although the filter will encode HTML, which we don't want here.
https://github.com/openshift/origin-web-console/pull/840
@Samuel thanks for the fast fix!
Checked on openshift v1.4.0-alpha.1+63e3797-264, now the color of url in quota shows well. The bug has been fixed, so move it to Verified.