Bug 1393002 - Review Request: perl-HTML-HTML5-Writer - Output a DOM as HTML5
Summary: Review Request: perl-HTML-HTML5-Writer - Output a DOM as HTML5
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-08 16:38 UTC by Petr Pisar
Modified: 2016-11-09 14:22 UTC (History)
2 users (show)

Fixed In Version: perl-HTML-HTML5-Writer-0.201-1.fc26
Clone Of:
Environment:
Last Closed: 2016-11-09 14:22:53 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2016-11-08 16:38:56 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-HTML-HTML5-Writer/perl-HTML-HTML5-Writer.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-HTML-HTML5-Writer/perl-HTML-HTML5-Writer-0.201-1.fc26.src.rpm
Description:
This Perl module outputs XML::LibXML::Node objects as HTML5 strings. It works
well on DOM trees that represent valid HTML/XHTML documents; less well on
other DOM trees.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-11-09 12:09:10 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-HTML-HTML5-Writer-0.201-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(:VERSION) >= 5.10.0
      1 perl(Exporter)
      1 perl(HTML::HTML5::Entities) >= 0.001
      1 perl(XML::LibXML) >= 1.60
      1 perl(base)
      1 perl(constant)
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-HTML-HTML5-Writer-0.201-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(HTML::HTML5::Writer) = 0.201
      1 perl-HTML-HTML5-Writer = 0.201-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-HTML-HTML5-Writer*
perl-HTML-HTML5-Writer.noarch: W: spelling-error %description -l en_US LibXML -> Lib XML, Lib-XML, Librium
perl-HTML-HTML5-Writer.src: W: spelling-error %description -l en_US LibXML -> Lib XML, Lib-XML, Librium
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2016-11-09 14:07:18 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-HTML-HTML5-Writer

Comment 3 Petr Pisar 2016-11-09 14:22:53 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.