Bug 1393330 - gnome-session: the special directorys(Documents Music Pictures) don't change the language after change the system language.
Summary: gnome-session: the special directorys(Documents Music Pictures) don't change ...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: gnome-shell-extensions
Version: 7.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Florian Müllner
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-09 10:47 UTC by xiaoli feng
Modified: 2021-01-15 07:28 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-01-15 07:28:27 UTC
Target Upstream Version:


Attachments (Terms of Use)

Description xiaoli feng 2016-11-09 10:47:30 UTC
Description of problem:
After change the system language, logout and login, the old name still be kept when choose update the old name. Click the old name, it shows "not found".

Verrsion-Release number of selected component (if applicable):
3.10.0-514.el7.x86_64

How reproducible:

100%
Steps to Reproduce:
1. Click Region & Language button, change the Language to another language
2. Popup window and click restart session button
3. Then click LogOut and Login, finally click update name button
4. Click the Places button on the top status bar, it shows the old name and new name

Actual results:
show the old and new language name on the Places when choose update the name 

Expected results:

show new language name on the Places when choose update the name

Additional info:

Comment 2 Ray Strode [halfline] 2016-11-10 20:01:14 UTC
what's the output of 

ls -ld ~/*

?

Comment 3 xiaoli feng 2016-11-11 01:48:55 UTC
(In reply to Ray Strode [halfline] from comment #2)
> what's the output of 
> 
> ls -ld ~/*
> 
> ?

It only shows the new language name. It seems don't update the "Places" window.

Comment 4 Ray Strode [halfline] 2016-11-11 16:05:52 UTC
i think this is probably a gnome-shell-extensions bug, but it might be a problem lower in the stack. We'll start there anyway.

Can you post the output of

$ cat ~/.config/gtk-3.0/bookmarks

and the output of

$ cat ~/.gtk-bookmarks

?

Comment 5 Florian Müllner 2016-11-14 11:28:31 UTC
I can reproduce the issue, but I doubt it's an easy fix:
 - special dirs are loaded for places menu
 - bookmarks are loaded for places menu (and de-duplicated with special dirs)
 - directory names are updated
 - bookmarks are reloaded (and de-duplication with special dirs no longer works because the files are now different)

Note that special directories are cached by glib, so reloading those wouldn't have any effect unless we change glib first. So the only option I can think of right now is to rely on special dirs also appearing in bookmarks, which sounds fragile.

Another option could be to offer to rename folders after changing the language instead of after the next login, so the change is picked up properly with one session restart instead of two.

(I'll also add that nautilus has exactly the same problem - until it is restarted, entries will be duplicated in the sidebar)

Comment 6 Ray Strode [halfline] 2016-11-14 14:55:33 UTC
what about g_reload_user_special_dirs_cache ?

Comment 7 Florian Müllner 2016-11-14 15:48:42 UTC
(In reply to Ray Strode [halfline] from comment #6)
> what about g_reload_user_special_dirs_cache ?

Mmh, yeah - I guess installing a file monitor for each special dir and queuing a reload on changes would work (in the extension, nautilus and gtk+ - forgot about the file chooser previously). Not sure the benefit justifies the additional resource usage, though I guess we can cut that down a bit by assuming that some bookmark will be effected by the change and thus monitoring the bookmarks file is sufficient ...

Comment 8 xiaoli feng 2016-11-15 02:36:12 UTC
(In reply to Ray Strode [halfline] from comment #4)
> i think this is probably a gnome-shell-extensions bug, but it might be a
> problem lower in the stack. We'll start there anyway.
> 
> Can you post the output of
> 
> $ cat ~/.config/gtk-3.0/bookmarks
> 
> and the output of
> 
> $ cat ~/.gtk-bookmarks
> 
> ?

Sorry for late. 

[fengxiaoli@dhcp-13-153 ~]$ cat ~/.config/gtk-3.0/bookmarks 
file:///home/fengxiaoli/%E6%96%87%E6%A1%A3
file:///home/fengxiaoli/%E9%9F%B3%E4%B9%90
file:///home/fengxiaoli/%E5%9B%BE%E7%89%87
file:///home/fengxiaoli/%E8%A7%86%E9%A2%91
file:///home/fengxiaoli/%E4%B8%8B%E8%BD%BD

There is no ~/.gtk-bookmarks file.

Comment 10 RHEL Program Management 2021-01-15 07:28:27 UTC
After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.


Note You need to log in before you can comment on or make changes to this bug.