Bug 1393708 - snapshot history button in infra vm page does not function properly
Summary: snapshot history button in infra vm page does not function properly
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.7.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: GA
: 5.8.0
Assignee: Zita Nemeckova
QA Contact: Aziza Karol
URL:
Whiteboard: infra:vm:snapshot
Depends On:
Blocks: 1395849
TreeView+ depends on / blocked
 
Reported: 2016-11-10 08:18 UTC by Aziza Karol
Modified: 2017-06-12 17:32 UTC (History)
7 users (show)

Fixed In Version: 5.8.0.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1395849 (view as bug list)
Environment:
Last Closed: 2017-06-12 17:32:31 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:


Attachments (Terms of Use)
accessing snapshot XX (226.78 KB, image/png)
2016-11-10 08:18 UTC, Aziza Karol
no flags Details
page redirected to snapshot YY (89.75 KB, image/png)
2016-11-10 08:19 UTC, Aziza Karol
no flags Details

Description Aziza Karol 2016-11-10 08:18:19 UTC
Created attachment 1219239 [details]
accessing snapshot XX

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
Viewing history link of snapshot VM xx redirects to the snapshot page of vm yy 
see attached screenshots

Actual results:
should redirect to proper page

Expected results:


Additional info:

Comment 2 Aziza Karol 2016-11-10 08:19:17 UTC
Created attachment 1219240 [details]
page redirected to snapshot YY

Comment 3 Aziza Karol 2016-11-10 08:20:38 UTC
Version:5.7.0.10-beta3.20161109111947_9a61b18

Comment 4 Harpreet Kataria 2016-11-10 17:40:52 UTC
Zita,

It looks like value of x_node here https://github.com/ManageIQ/manageiq/blob/master/app/controllers/vm_common.rb#L1807-L1809 is the id of selected parent folder node of a VM which is messing up the history link when VMs are hidden in the tree. Can you take a look and fix the id that is being passed in to x_history_add_item method. Let me know if you have any questions. Please look at any other calls to x_history_add_item method as well to make sure they all work as expected.

Thanks,
~Harpreet

Comment 6 Šimon Lukašík 2016-11-15 08:17:35 UTC
https://github.com/ManageIQ/manageiq/pull/12614

Comment 7 CFME Bot 2016-11-16 17:46:04 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/adbe1faf05a8cf6c6fd01a7a1e87827c7b5ba6e9

commit adbe1faf05a8cf6c6fd01a7a1e87827c7b5ba6e9
Author:     Martin Hradil <himdel>
AuthorDate: Wed Nov 16 14:19:51 2016 +0200
Commit:     Oleg Barenboim <chessbyte>
CommitDate: Wed Nov 16 12:36:09 2016 -0500

    Merge pull request #12614 from ZitaNemeckova/fix_history_button_vm
    
    Fix history button in vm infra page
    (cherry picked from commit 804cf5e66e28d6370333148c4f2affc47a61de35)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1393708

 app/controllers/mixins/vm_show_mixin.rb |  2 +-
 app/controllers/vm_common.rb            | 29 +++++++++++++++++++++++------
 2 files changed, 24 insertions(+), 7 deletions(-)

Comment 9 Aziza Karol 2017-03-10 07:46:56 UTC
snapshot history button in infra vm page works fine.

Verified:5.8.0.4.20170307183144_745a3d9


Note You need to log in before you can comment on or make changes to this bug.