Bug 1393845 - [RFE] Automatically adjust hot plug memory, or indicate the delta unit
Summary: [RFE] Automatically adjust hot plug memory, or indicate the delta unit
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: RestAPI
Version: 4.0.5.5
Hardware: Unspecified
OS: Unspecified
unspecified
medium vote
Target Milestone: ---
: ---
Assignee: Michal Skrivanek
QA Contact: Israel Pinto
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-10 12:48 UTC by Juan Hernández
Modified: 2020-04-01 14:50 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-04-01 14:47:14 UTC
oVirt Team: Virt
michal.skrivanek: ovirt-future?
rule-engine: planning_ack?
rule-engine: devel_ack?
rule-engine: testing_ack?


Attachments (Terms of Use)

Description Juan Hernández 2016-11-10 12:48:37 UTC
Currently hot plugging memory to a virtual machine requires that the delta is a multiple of 256 MiB, and clients need to be aware of this and provide the right size, otherwise the memory isn't updated. We need either modify the engine so that it adjusts the memory so that it will work, or else provide in the API a mechanism for the client to find out this value. For example:

  GET /ovirt-engine/api/clusters/123
  <cluster_level>
    ...
    <memory_policy>
      ...
      <hot_plug_delta_unit>268435456</hot_plug_delta_unit>
      ...
    </memory_policy>
    ...
  </cluster_level>

Not 100% sure if the cluster is the right place for this.

Comment 1 Yaniv Kaul 2016-11-11 07:10:03 UTC
We should probably begin with proper documentation.

Comment 2 Michal Skrivanek 2016-11-11 08:40:12 UTC
the granularity of hotplug is a CL/arch detail. I suggested to add API for generic VdcOptions access holding these values. Support of hot(un)plug is also in osinfo which doesn't have API either today. Also could be added

Adding specificic items to API for each of VdcOption value kind of defeats the purpose of a general low-level configuration store.

Alternatively it was suggested to round up the requested numbers. That's also possible

Comment 3 Michal Skrivanek 2020-03-19 15:40:52 UTC
We didn't get to this bug for more than 2 years, and it's not being considered for the upcoming 4.4. It's unlikely that it will ever be addressed so I'm suggesting to close it.
If you feel this needs to be addressed and want to work on it please remove cond nack and target accordingly.

Comment 4 Michal Skrivanek 2020-04-01 14:47:14 UTC
ok, closing. Please reopen if still relevant/you want to work on it.

Comment 5 Michal Skrivanek 2020-04-01 14:50:53 UTC
ok, closing. Please reopen if still relevant/you want to work on it.


Note You need to log in before you can comment on or make changes to this bug.