Hide Forgot
Description of problem: Not all connections have an interface name Version-Release number of selected component (if applicable): 122-1 How reproducible: Always Additional info: Fixed upstream d957f9e682a8bd5a9e005b730ce5a7f5317b2ed7
Upstream master commit https://github.com/cockpit-project/cockpit/commit/5d3f012faf468235954083312b1bd15ac8fc29c8
We should describe the actual problem caused by this bug before approving it for a patch. Dominik, do you have that information?
Here is the background for the patch: Cockpit builds a internal data structure that is derived from the information exposed by NetworkManager. Specifically, it finds all names of interfaces that don't currently exist in the kernel but can be potentially created by activating existing connection settings for bridges, bonds, teams, or vlans. Previously, Cockpit assumed that all connection settings for bridges, bonds, teams, and vlans have a value for the "interface-name" property. It would crash if a setting didn't have a value. These kind of incomplete settings are legal and work okay with NetworkManager. We would need more work in Cockpit to also make them work okay in the UI.
This patch prevents (In reply to Marius Vollmer from comment #3) > Previously, Cockpit assumed that all connection settings for bridges, bonds, > teams, and vlans have a value for the "interface-name" property. It would > crash if a setting didn't have a value. We want to prevent said crash.
current version contains the patch