Bug 1395540 - PHP 7 compatibility
Summary: PHP 7 compatibility
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: libpuzzle
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Remi Collet
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-16 06:59 UTC by Remi Collet
Modified: 2016-12-05 21:41 UTC (History)
2 users (show)

Fixed In Version: libpuzzle-0.11-30.fc25
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-12-05 21:41:54 UTC
Type: Bug


Attachments (Terms of Use)
libpuzzle-0.11-pkgconfig.patch (1.67 KB, text/plain)
2016-11-16 07:00 UTC, Remi Collet
no flags Details
libpuzzle-0.11-php7.patch (5.06 KB, text/plain)
2016-11-16 07:01 UTC, Remi Collet
no flags Details
libpuzzle.spec.patch (2.11 KB, text/plain)
2016-11-16 07:01 UTC, Remi Collet
no flags Details

Description Remi Collet 2016-11-16 06:59:13 UTC
During mass rebuild for PHP 7.1, I notice you have to patch for PHP 7, if this minimal patch is enough for "build" it will create stack corruption at runtime because of zend_parse_parameters.

Attached patches should fix this.

I don't find upstream SCM (project seems dead), so I haven't submit them.

Comment 1 Remi Collet 2016-11-16 07:00:22 UTC
Created attachment 1221040 [details]
libpuzzle-0.11-pkgconfig.patch

To avoid deprecation warnings during configure

Comment 2 Remi Collet 2016-11-16 07:01:02 UTC
Created attachment 1221042 [details]
libpuzzle-0.11-php7.patch

PHP 5 and 7 compatibility

Comment 3 Remi Collet 2016-11-16 07:01:27 UTC
Created attachment 1221043 [details]
libpuzzle.spec.patch

Comment 4 Remi Collet 2016-11-16 07:19:29 UTC
Also saved in private-30 branch, so you can simply merge the work:

http://pkgs.fedoraproject.org/cgit/rpms/libpuzzle.git?h=private-30

Comment 5 Remi Collet 2016-11-24 08:11:40 UTC
private branch merged

Comment 6 Fedora Update System 2016-11-24 08:12:28 UTC
libpuzzle-0.11-30.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-4c39bd4a6d

Comment 7 Fedora Update System 2016-11-25 09:42:51 UTC
libpuzzle-0.11-30.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4c39bd4a6d

Comment 8 Fedora Update System 2016-12-05 21:41:54 UTC
libpuzzle-0.11-30.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.