Bug 1396601 - Incompatibility with erfa 1.3.0
Summary: Incompatibility with erfa 1.3.0
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-astropy
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Sergio Pascual
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-18 18:07 UTC by Orion Poplawski
Modified: 2016-11-22 20:07 UTC (History)
1 user (show)

Fixed In Version: python-astropy-1.2.1-5.fc26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-22 20:07:09 UTC
Type: Bug


Attachments (Terms of Use)
spec (16.99 KB, text/plain)
2016-11-18 18:07 UTC, Orion Poplawski
no flags Details
spec (16.99 KB, text/plain)
2016-11-18 18:43 UTC, Orion Poplawski
no flags Details
spec (14.86 KB, text/plain)
2016-11-21 23:13 UTC, Orion Poplawski
no flags Details

Description Orion Poplawski 2016-11-18 18:07:43 UTC
Created attachment 1221930 [details]
spec

Description of problem:

With the system erfa 1.3.0, test_sidereal fails:

_____________ ERROR collecting astropy/time/tests/test_sidereal.py _____________
astropy/time/tests/test_sidereal.py:24: in <module>
    class TestERFATestCases():
astropy/time/tests/test_sidereal.py:34: in TestERFATestCases
    assert np.allclose(time_ut1.tt.jd2 - time_tt.jd2, 0., atol=1.e-14)
E   assert False
E    +  where False = <function allclose at 0xf4fce80c>((-0.4999999999999999 - 0.5), 0.0, atol=1e-14)
E    +    where <function allclose at 0xf4fce80c> = np.allclose
E    +    and   -0.4999999999999999 = <Time object: scale='tt' format='jd' value=2453735.5>.jd2
E    +      where <Time object: scale='tt' format='jd' value=2453735.5> = <Time object: scale='ut1' format='jd' value=2453736.5>.tt
E    +    and   0.5 = <Time object: scale='tt' format='jd' value=2453736.5>.jd2

See https://github.com/astropy/astropy/pull/5466 for more details.

I'm proposing we build with the bundled erfa for now until this is resolved.

I'd also like to build with the bundled wcslib on EPEL.  See attached spec for details.  Although we do have an issue with an old scipy in EPEL at the moment.

Version-Release number of selected component (if applicable):
1.2.1-4.fc26

Comment 1 Orion Poplawski 2016-11-18 18:43:27 UTC
Created attachment 1221968 [details]
spec

Fix conditional

Comment 3 Sergio Pascual 2016-11-21 22:40:21 UTC
What version of erfa do you need in epel?

Comment 4 Orion Poplawski 2016-11-21 22:50:22 UTC
Current erfa is fine in EPEL.  But with erfa 1.3.0, I think we should build with bundled erfa.

scipy is blocking updating astropy in EPEL though.

If you're okay with proposed spec I'll check that into master as build.

Comment 5 Sergio Pascual 2016-11-21 22:58:04 UTC
You have uploaded a different spec, protobuf?

Comment 6 Orion Poplawski 2016-11-21 23:13:26 UTC
Created attachment 1222497 [details]
spec

Ah, trying to do too many things at once again.  How about this?

Comment 7 Sergio Pascual 2016-11-21 23:27:42 UTC
Fantastic, please go ahead and thank you

Comment 8 Orion Poplawski 2016-11-22 20:07:09 UTC
ppc64 builds are still unstable unfortunately (due to bug #1394975), but managed to get a build to complete.


Note You need to log in before you can comment on or make changes to this bug.