Bug 1396922 - Review Request: python-yarl - A Python module to handle URLs
Summary: Review Request: python-yarl - A Python module to handle URLs
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Igor Gnatenko
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1396923 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-21 08:37 UTC by Fabian Affolter
Modified: 2017-03-11 19:32 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-03-11 19:32:32 UTC
Type: ---
Embargoed:
ignatenko: fedora-review+


Attachments (Terms of Use)

Description Fabian Affolter 2016-11-21 08:37:26 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-yarl.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-yarl-0.7.1-1.fc24.src.rpm

Project URL: http://pythonhosted.org/yarl/

Description:
The module provides handy URL class for url parsing and changing.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16551043

rpmlint output:
[fab@laptop016 SRPMS]$ rpmlint python-yarl-0.7.1-1.fc24.src.rpm 
python-yarl.src: W: spelling-error %description -l en_US url -> URL, curl, purl
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[fab@laptop016 x86_64]$ rpmlint python*-yarl-*
python3-yarl.x86_64: W: spelling-error %description -l en_US url -> URL, curl, purl
python3-yarl.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.5/site-packages/yarl/_quoting.c
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Fedora Account System Username: fab

Comment 1 Igor Gnatenko 2016-11-21 08:57:41 UTC
* No need for "A" in summary, it's making it more unreadable
* It's better to take archive out of GitHub, not from PyPI (especially when it comes down to Cython, why checks if it uses Cython to generate code or uses pre-generated code)
* python3-yarl.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.5/site-packages/yarl/_quoting.c -> please report bug to upstream and make note in spec
* Tests are not executed, but present
* %{python3_sitearch}/%{srcname}*.egg-info -> %{python3_sitearch}/%{srcname}-*.egg-info/ (trailing slash is needed for RPM to not accept files, disutils uses file, setuptools uses directory)

ALMOST GOOD.

Comment 2 Fabian Affolter 2016-11-22 13:52:37 UTC
*** Bug 1396923 has been marked as a duplicate of this bug. ***

Comment 3 Igor Gnatenko 2017-01-01 15:17:48 UTC
ping?

Comment 4 Fabian Affolter 2017-01-21 12:20:56 UTC
Sorry for the delay and thanks for the remarks.

Comment 5 Fabian Affolter 2017-01-21 13:05:17 UTC
* Sat Jan 21 2017 Fabian Affolter <mail> - 0.8.1-1
- Update to latest upstream release 0.8.1
- Remove _quoting.c

* Mon Nov 21 2016 Fabian Affolter <mail> - 0.7.1-2
- Update Source0, summary

Updated files: 
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-yarl.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-yarl-0.8.1-1.fc24.src.rpm

Comment 6 Igor Gnatenko 2017-01-21 13:10:43 UTC
Would be nice to get comment why tests are commented out in spec. No other issues.

P.S. would be happy if you will add me as co-maintainer

Comment 7 Gwyn Ciesla 2017-01-23 14:10:01 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-yarl


Note You need to log in before you can comment on or make changes to this bug.