Bug 1397317 - Review Request: graphene - A thin layer of types for graphic libraries
Summary: Review Request: graphene - A thin layer of types for graphic libraries
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Igor Gnatenko
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1409666
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-22 10:08 UTC by Kalev Lember
Modified: 2017-03-11 19:33 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-03-11 19:33:35 UTC
Type: ---
Embargoed:
ignatenko: fedora-review+


Attachments (Terms of Use)

Description Kalev Lember 2016-11-22 10:08:09 UTC
Spec URL: https://kalev.fedorapeople.org/graphene.spec
SRPM URL: https://kalev.fedorapeople.org/graphene-1.5.1-0.1.git8a7a4a3.fc26.src.rpm
Description:
Graphene provides a small set of mathematical types needed to implement graphic
libraries that deal with 2D and 3D transformations and projections.

Fedora Account System Username: kalev

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16560894

Comment 1 Igor Gnatenko 2016-11-22 10:20:38 UTC
This packaging has some issues, please take proper one from https://fedorapeople.org/cgit/ignatenkobrain/public_git/graphene.git/plain/graphene.spec.

in short, libexecdir should be used for tests. Multiple unowned directories.

Though keep excludearch.

Comment 2 Kalev Lember 2016-11-22 10:40:11 UTC
Thanks for looking at this, Igor. Can you elaborate on the multiple unowned directories? I can't see any.

* Tue Nov 22 2016 Kalev Lember <klember> - 1.5.1-0.2.git8a7a4a3
- Install installed tests to libexecdir (#1397317)

Spec URL: https://kalev.fedorapeople.org/graphene.spec
SRPM URL: http://kalev.fedorapeople.org/graphene-1.5.1-0.2.git8a7a4a3.fc26.src.rpm

Comment 3 Igor Gnatenko 2016-11-22 11:02:20 UTC
argh, I didn't see the owning dir.

It looks good, however I would prefer to:
* `%global nsver 1.0` and use it wherever Graphene-%{nsver}... applies. It will be faster to replace in one place instead of all places.
* Be more specfic about directories. Owning girepository/gir works, but would be nice to specify exact files there
* Use patch instead of moving files ;)

Kalev, can you also add me as co-maintainer when you will request new package in pkgdb?

Comment 4 Kevin Fenzi 2017-01-02 21:21:26 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/graphene

Comment 5 Igor Gnatenko 2017-01-02 22:45:02 UTC
Built for F25+, F24 is blocked.

Comment 6 Kalev Lember 2017-01-09 11:22:16 UTC
Thanks Igor! I'm happy to maintain graphene, feel free to change the point of contact to me if you want.


Note You need to log in before you can comment on or make changes to this bug.