Bug 1397489 - Engine does not check for input validity in external network subnet window
Summary: Engine does not check for input validity in external network subnet window
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Network
Version: future
Hardware: x86_64
OS: Linux
unspecified
medium vote
Target Milestone: ---
: ---
Assignee: Dan Kenigsberg
QA Contact: Meni Yakove
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-22 16:04 UTC by Mor
Modified: 2016-11-23 09:37 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-23 09:37:06 UTC
oVirt Team: Network
mkalfon: planning_ack?
mkalfon: devel_ack?
mkalfon: testing_ack?

Attachments (Terms of Use)
Add an attachment (proposed patch, testcase, etc.)

Description Mor 2016-11-22 16:04:00 UTC 
Description of problem:
In the subnet creation window, "Name" and "Gateway" fields are not being checked for input validity.

Version-Release number of selected component (if applicable):
oVirt engine: 4.1.0-0.0.master.20161120231325.gitba51756.el7.centos

How reproducible:
100%

Steps to Reproduce:
1. Create new OVN network and select the subnet tab.
2. In the name input field, try to type a very long string.
3. In the gateway input field, try to type invalid IP address: 254.254.254.254. 

Actual results:
Engine accepts invalid user input.

Expected results:
Engine should verify that the gateway is a valid IP address (e.g. by using regex), and name field should be restricted according to OVS.


Additional info:
Comment 1 Yaniv Lavi 2016-11-23 09:37:06 UTC 
We will be fixing this when we create a UI from the OVN provider. This will mean removing the current UI for this. Closing for now.
Note You need to log in before you can comment on or make changes to this bug.