Bug 1397603 - pmchart can't select current chart without invoking instance/value dialog
Summary: pmchart can't select current chart without invoking instance/value dialog
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: pcp
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Nathan Scott
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-11-22 23:25 UTC by Mark Goodwin
Modified: 2017-01-19 05:53 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-01-19 05:53:59 UTC
Type: Bug


Attachments (Terms of Use)

Description Mark Goodwin 2016-11-22 23:25:07 UTC
Description of problem: was testing the new pmchart feature to pop up an instance/value list via left-mouse selection - love it! But this now seems to have overridden the ability to select the current chart (for editing, e.g. with Edit/Chart). In addition, there is no longer any visual indication of the current chart. (You can actually select the current chart, but only by invoking the dialog).

One other nasty effect is that a chart with no plots (e.g. due to a broken view being loaded), can't be selected and hence can't be deleted or edited.

I guess maybe we need to use the middle or right mouse button to select the current chart? Or perhaps change to using middle mouse to pop up the instance/values dialog?

Version-Release number of selected component (if applicable): pcp-3.11.6-1

Comment 1 Dave Brolley 2016-11-24 21:20:03 UTC
Interesting. My intent was to add the pop up window *in addition* to what was already being done when left clicking on a chart. I'm wondering if popping up the window as the last action taken has somehow undone the selection of the chart.

The original RFE for the pop up did request use of the right mouse button, but I was unable to find support for that in the ChartPicker class.

Comment 2 Nathan Scott 2016-11-24 21:58:47 UTC
IIRC its a more generic event, Dave, supported by all widgets - (looking in ChartPicker & QwtPicker might not find it as a result)

    http://doc.qt.io/qt-4.8/qmouseevent.html

The double-click event might be another option (QEvent::MouseButtonDblClick) - some platforms have single-button mice (Mac) - perhaps both double click and right click could be intercepted for this popup.

Comment 3 Mark Goodwin 2016-11-24 23:31:53 UTC
>
> double click and right click could be intercepted for this popup.

that would work. The other thing is the highlighting of the current chart seems to have been lost.

My use-case the other day was a series of charts plotting per-cpu/per-IRQ interrupt rates on a 20-CPU/2-node VMware guest system (with Legend off for obvious reasons!), and trying to figure out which interrupts were misbehaving on the guest after it was vMotion'ed from one hypervisor to another .. and to correlate this with other system level activity on both the guest and the two hypervisors. The instance/value popup was very useful here.

Another obvious use-case is charting per-process metrics - the legend and color schemes are basically useless because there are simply too many instances.

Comment 4 Nathan Scott 2017-01-19 05:53:59 UTC
Resolved in the pcp-3.11.7 release (Dec 2016).


Note You need to log in before you can comment on or make changes to this bug.